Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: signature package #3653

Merged
merged 2 commits into from
Feb 26, 2023
Merged

feat: signature package #3653

merged 2 commits into from
Feb 26, 2023

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented Feb 26, 2023

extract token signatures and crypto utils to reuse un v5

@juanpicado juanpicado added this to the v6 release milestone Feb 26, 2023
describe('verifyJWTPayload', () => {
test('should verify the token and return a remote user', async () => {
const remoteUser = createRemoteUser('foo', []);
const token = await signPayload(remoteUser, '12345');

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "12345" is used as [key](1).

describe('test deprecated crypto utils', () => {
test('decrypt payload flow', () => {
const secret = generateRandomSecretKeyDeprecated();

Check failure

Code scanning / CodeQL

Insecure randomness

This uses a cryptographically insecure random number generated at [pseudoR ... length)](1) in a security context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant