-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update many package deps including babel, @types & more #2395
Conversation
@juanpicado If you let me know which is the low hanging fruit for further dep updates from the Possible suggestions might include:
Note: the following are problematic (tried already and either build or test failed):
|
@juanpicado I've figured out how to upgrade Also there seems to be a benefit in upgrading to Typing improvements are always a good idea but I hesitate to do this in this PR. May I suggest an issue be created to update |
I'd not touch
Yes, maybe a new PR, just maybe if you haven't noticed, the Node.js 16 is not enabled on CI because months ago tests were failing, so maybe make sense double-check in a separated PR. I haven't check the whole PR, just quick reply :) about the questions above. |
I think best let things settle down for a while after this PR gets in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@indiescripter you have write permissions to work directly on this repo since you are part of the @verdaccio/collaborators group. |
I think something got broken on master.
|
Maybe we should align website and rest of the project, currently are using different setup of eslint and prettier. |
@juanpicado
|
yes, feel free to create a branch on this repo, you could prefix it as |
devDeps including babel, @types/*, autocannon
deps react, react-dom and a few others
Note: @types/node requires code changes so leaving unchanged for the moment
What I've found with updating dependencies is that doing too many in one go sometimes results in tests failing.
Then you have absolutely no idea which dep version change was the problem so you have to start over and do them one by one with a tedious pnpm install/build/test cycle.
Anyway, if this PR is accepted then the state of stale versions according to
pnpm -r outdated
report will be as follows: