feat: migrate Verdaccio.org to Docusaurus v2 and new design #2343

semoal · 2021-07-21T18:36:46Z

First of all, we should give thanks to @ploh007, for his amazing contribution gifting us this design.

Pending to-do's (In order)

Integrate Crowdin, I already know how to do this, just need some conversations with Juan (Api keys, and some details..).
Integrate Netlify, probably we can do this together too Juan, I want to introduce a netlify.toml, to add a cache of Docusaurus build, since under the hood uses Webpack 5 it contains persistent caching, which means consequent builds will be a lot faster. Example: https://github.com/facebook/docusaurus/blob/master/website/netlify.toml

Less relevant

Contact Algolia once released, to add the API_KEY for an amazing search experience.

Demo

Kapture.2021-07-21.at.20.35.38.mp4

juanpicado · 2021-07-21T18:39:28Z

@semoal ~~could you commit something small, I just enabled netlify preview for this branch.~~ Nevermind, I just read the comment 🙃

juanpicado · 2021-07-21T18:45:47Z

Regarding Aligolia, we just need to PR here any future change

https://github.com/algolia/docsearch-configs/blob/master/configs/verdaccio.json

semoal · 2021-07-21T18:46:46Z

Regarding Aligolia, we just need to PR here any future change

https://github.com/algolia/docsearch-configs/blob/master/configs/verdaccio.json

They'll do it automatically for us, we just need to ping them

github-actions · 2021-07-23T11:23:43Z

🚀 Netlify deployed trusting-mahavira-cc06c7 as draft

https://60faa6b057c493c1405a57ca--trusting-mahavira-cc06c7.netlify.app

github-actions · 2021-07-23T11:23:54Z

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟠 Performance	85
🟢 Accessibility	97
🟢 Best practices	100
🟠 SEO	81

Lighthouse ran on https://610005fd3cc6931dd69db5ed--trusting-mahavira-cc06c7.netlify.app/

github-actions · 2021-07-23T22:00:38Z

🚀 Netlify deployed trusting-mahavira-cc06c7 as draft

https://60fb3bf80caa6700a16fe2e0--trusting-mahavira-cc06c7.netlify.app

semoal · 2021-07-23T22:09:07Z

Well @juanpicado we're almost ready to 🚢.

Crowdin

Crowdin as you could check it's correctly imported with the new layout of translations, everything is translated as previously, there were a lot of buggy markdown's, I had to review one file per one haha. Also I've had to create a tool (https://github.com/semoal/mdx-localized-headings) for migrating translated headings with their correspondent ids, because translated documents didn't worked fine with the links. Now, everything will run smoothly.

Netlify

Also it's working perfectly fine, we should disable from the Netlify panel the auto build since we already do this operation. Also, I recommended changing the site name to verdaccio.netlify.com or something like that, in that way the deployment previews looks a bit nicer.

Known issues

Safari IOS, circles inside Twitter Carrousel are not working properly.
Safari IOS, lazy loaded iframes + twitter not working fine.

I'll look into this issues tomorrow early, in that way we can ship the website on Monday/Sunday whenever you want :)

juanpicado · 2021-07-24T06:47:18Z

Awesome !! I'll check today

✅ Auto build disabled

website/docusaurus.config.js

website/package.json

github-actions · 2021-07-26T11:39:58Z

🚀 Netlify deployed trusting-mahavira-cc06c7 as draft

https://60fe9f018d064d14674adfd7--trusting-mahavira-cc06c7.netlify.app

github-actions · 2021-07-26T11:40:37Z

🚀 Netlify deployed trusting-mahavira-cc06c7 as draft

https://60fe9f27f218c412b1d420e6--trusting-mahavira-cc06c7.netlify.app

semoal · 2021-07-26T12:15:39Z

All the issues are fixed, we just need to add the Crowdin keys to secrets, and we're ready to go!

github-actions · 2021-07-26T12:18:44Z

🚀 Netlify deployed trusting-mahavira-cc06c7 as draft

https://60fea815f4aee12a6449060b--trusting-mahavira-cc06c7.netlify.app

github-actions · 2021-07-26T16:59:51Z

🚀 Netlify deployed trusting-mahavira-cc06c7 as draft

https://60fee9f7e0c9260b794c3918--trusting-mahavira-cc06c7.netlify.app

juanpicado · 2021-07-26T19:56:11Z

@semoal I had to downgrade [email protected], there is an issue with the next minor.

github-actions · 2021-07-26T19:57:47Z

🚀 Netlify deployed trusting-mahavira-cc06c7 as draft

https://60ff13acc14e19444aaa3a80--trusting-mahavira-cc06c7.netlify.app

juanpicado

LGTM 💯 great job, your contribution is huge 👏🏼
Tested: mobile, local build, deployment, all good by far.

semoal · 2021-07-26T20:43:55Z

LGTM 💯 great job, your contribution is huge 👏🏼

Tested: mobile, local build, deployment, all good by far.

Thanks to you Juan. Looking forward to contribute even more

juanpicado · 2021-07-26T20:45:23Z

How do we solve the API_KEY for aligolia? Do I need to take an action here?

semoal · 2021-07-26T20:58:59Z

How do we solve the API_KEY for aligolia? Do I need to take an action here?

Probably the current one will work, let me ask to Algolia team.

github-actions · 2021-07-27T11:18:36Z

🚀 Netlify deployed trusting-mahavira-cc06c7 as draft

https://60ffeb7eaefc14e509f47d93--trusting-mahavira-cc06c7.netlify.app

github-actions · 2021-07-27T13:11:40Z

🚀 Netlify deployed trusting-mahavira-cc06c7 as draft

https://610005fd3cc6931dd69db5ed--trusting-mahavira-cc06c7.netlify.app

semoal · 2021-07-27T13:13:49Z

Ready to ship

Sergio Moreno added 4 commits July 21, 2021 20:15

feat: replace old website by the new one

16080d8

chore: move docs/website to website/docs

dc49c78

fix: images pointing to wrong url's

fb07b77

chore: improve markdown code

25b7a86

juanpicado added the website label Jul 21, 2021

Sergio Moreno added 4 commits July 21, 2021 20:49

chore: added heading id's for enable translating

20f167e

chore: netlify.toml with prod and preview commands

5456a6e

chore: set-up crowdin ready

8bec8ef

chore: remove esbuild - incompatible with pnpm

31269c7

semoal force-pushed the new-website-ooo branch 4 times, most recently from 88a6f14 to ab506c2 Compare July 21, 2021 19:45

chore: update netlify.toml on root

782d163

semoal force-pushed the new-website-ooo branch from ab506c2 to 782d163 Compare July 21, 2021 19:47

Sergio Moreno added 4 commits July 21, 2021 21:50

chore: branch-deploy context

fbf767e

chore: change directory

2cf8c07

ci: add website github action and esbuild back

187151c

feat: added Ligththouse to Website CI

e93ac5c

fix: crowdin functional

ffda95f

juanpicado reviewed Jul 24, 2021

View reviewed changes

website/docusaurus.config.js Outdated Show resolved Hide resolved

juanpicado reviewed Jul 24, 2021

View reviewed changes

website/package.json Show resolved Hide resolved

Sergio Moreno added 3 commits July 26, 2021 13:19

chore: only enable locales with good translation ratio

3456d1e

chore: clean up deps and moved @types to root

f5f5f5a

Merge branch 'master' into new-website-ooo

581b784

fix: youtube iframe videos mobile not responsive

9948628

fix: twitter tweets on safari and circles not respecting overflow

069d307

semoal force-pushed the new-website-ooo branch from 6e23614 to 069d307 Compare July 26, 2021 12:16

chore: downgrade pnpm to v6.10.3

a80b187

chore: downgrade to pnpm v6.10.3

9ff4f8d

juanpicado previously approved these changes Jul 26, 2021

View reviewed changes

fix: added algolia api_key and crowdin to editUrls

242ce78

semoal dismissed juanpicado’s stale review via 242ce78 July 27, 2021 11:16

semoal marked this pull request as ready for review July 27, 2021 11:48

feat: added google analytics and sentry

7ffe109

juanpicado approved these changes Jul 27, 2021

View reviewed changes

semoal merged commit a6b0d63 into master Jul 27, 2021

semoal deleted the new-website-ooo branch July 27, 2021 19:52

snyk-bot mentioned this pull request Jan 17, 2022

[Snyk] Security upgrade marked from 3.0.8 to 4.0.10 #2917

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: migrate Verdaccio.org to Docusaurus v2 and new design #2343

feat: migrate Verdaccio.org to Docusaurus v2 and new design #2343

semoal commented Jul 21, 2021 •

edited

Loading

juanpicado commented Jul 21, 2021 •

edited

Loading

juanpicado commented Jul 21, 2021

semoal commented Jul 21, 2021

github-actions bot commented Jul 23, 2021

github-actions bot commented Jul 23, 2021 •

edited

Loading

github-actions bot commented Jul 23, 2021

semoal commented Jul 23, 2021 •

edited

Loading

juanpicado commented Jul 24, 2021 •

edited

Loading

github-actions bot commented Jul 26, 2021

github-actions bot commented Jul 26, 2021

semoal commented Jul 26, 2021

github-actions bot commented Jul 26, 2021

github-actions bot commented Jul 26, 2021

juanpicado commented Jul 26, 2021

github-actions bot commented Jul 26, 2021

juanpicado left a comment

semoal commented Jul 26, 2021

juanpicado commented Jul 26, 2021

semoal commented Jul 26, 2021

github-actions bot commented Jul 27, 2021

github-actions bot commented Jul 27, 2021

semoal commented Jul 27, 2021

feat: migrate Verdaccio.org to Docusaurus v2 and new design #2343

feat: migrate Verdaccio.org to Docusaurus v2 and new design #2343

Conversation

semoal commented Jul 21, 2021 • edited Loading

Pending to-do's (In order)

Less relevant

Demo

juanpicado commented Jul 21, 2021 • edited Loading

juanpicado commented Jul 21, 2021

semoal commented Jul 21, 2021

github-actions bot commented Jul 23, 2021

github-actions bot commented Jul 23, 2021 • edited Loading

github-actions bot commented Jul 23, 2021

semoal commented Jul 23, 2021 • edited Loading

Crowdin

Netlify

Known issues

juanpicado commented Jul 24, 2021 • edited Loading

github-actions bot commented Jul 26, 2021

github-actions bot commented Jul 26, 2021

semoal commented Jul 26, 2021

github-actions bot commented Jul 26, 2021

github-actions bot commented Jul 26, 2021

juanpicado commented Jul 26, 2021

github-actions bot commented Jul 26, 2021

juanpicado left a comment

Choose a reason for hiding this comment

semoal commented Jul 26, 2021

juanpicado commented Jul 26, 2021

semoal commented Jul 26, 2021

github-actions bot commented Jul 27, 2021

github-actions bot commented Jul 27, 2021

semoal commented Jul 27, 2021

semoal commented Jul 21, 2021 •

edited

Loading

juanpicado commented Jul 21, 2021 •

edited

Loading

github-actions bot commented Jul 23, 2021 •

edited

Loading

semoal commented Jul 23, 2021 •

edited

Loading

juanpicado commented Jul 24, 2021 •

edited

Loading