Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace node-fetch by undici hook package #2292

Merged
merged 7 commits into from
Jun 12, 2021
Merged

chore: replace node-fetch by undici hook package #2292

merged 7 commits into from
Jun 12, 2021

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented Jun 12, 2021 •
edited
Loading

  • Learning using undici / undici-fetch by replacing node-fetch on small package.
  • Replace nock on that package by built in mock client.

https://undici.nodejs.org/#/docs/api/MockPool?id=mockpoolclose
https://undici-fetch.dev/#/

Refers: #1807

⚠️ undify-fetch target Node.js 14 as minimum, disable test on Node v12 (will be completely deprecated in a follow up).

@juanpicado juanpicado added this to the Next major milestone Jun 12, 2021
@juanpicado juanpicado merged commit d6e44a4 into master Jun 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the jota/undici-test branch June 12, 2021 16:24
@juanpicado juanpicado modified the milestones: Next major, v6 release Nov 3, 2021
@juanpicado juanpicado mentioned this pull request Mar 5, 2022
Merged
@juanpicado juanpicado modified the milestones: v6 release, Next major Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dev: refactor
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
1 participant
@juanpicado