Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

fix: changes font size for items of the register-info component #196

Merged
merged 3 commits into from
Oct 15, 2019

Conversation

smithandrewl
Copy link
Contributor

Type: bug

Description: This changes the font size for items of the register-info component to 1rem. Using the inspector tool, the visible difference between the "correct" and "incorrect" versions of the register-info components was the font size. The correct/before component had a font-size of 1rem. This change sets the font size back to 1rem and the text is no longer cut-off at the bottom.

Resolves #193

This changes the font size for items of the register-info component to 1rem
Fixes #193.
@juanpicado juanpicado self-requested a review October 13, 2019 19:56
juanpicado
juanpicado previously approved these changes Oct 13, 2019
Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@juanpicado
Copy link
Member

Please run yarn test -u and upload snapshots.

@codecov
Copy link

codecov bot commented Oct 13, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@cfb29ce). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #196   +/-   ##
=========================================
  Coverage          ?   88.73%           
=========================================
  Files             ?      117           
  Lines             ?      932           
  Branches          ?      168           
=========================================
  Hits              ?      827           
  Misses            ?       89           
  Partials          ?       16
Impacted Files Coverage Δ
src/components/CopyToClipBoard/styles.ts 100% <ø> (ø)

Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 🚀

@juanpicado juanpicado merged commit 6f87be6 into verdaccio:master Oct 15, 2019
@smithandrewl smithandrewl deleted the typography_fix branch October 15, 2019 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong test on Registry Info
2 participants