DetailContainer Component - Replaced class by func. comp #130
Conversation
|
Test are failing, could you check @priscilawebdev https://app.circleci.com/jobs/github/verdaccio/ui/1522 ? |
|
@juanpicado I have increased the PR's size, (if you prefer I can split the PR) but tests are passing 🙂 |
|
@sergiohgz I would like to start organizing the components in order to implement our Theme...after they will be together again..i just find this way easier for now... |
|
@priscilawebdev perfect if we use it as workaround for organizing, but I think this approach should not be permanent 😉 |
priscilawebdev
changed the title
Let's make a document about how this process would take place. It's a way all we are in the same page. https://drive.google.com/drive/folders/0B7N5pSnWAO88S0lmQUpiU0laWWM |
delete-merged-branch
bot
deleted the
refactor/116_react_hooks_detail_container
branch
Type: Refactor
The following has been addressed in the PR: https://github.com/verdaccio/ui/issues/116
Unit or Functional tests are included in the PR?
Not completely
Description:
in order to use react hooks, in this PR I updated the DetailContainer component by changing it from a class to a functional component. I have also splitted it's content so that it is clearer.
I didn't add tests using the react testing library now, because the content of a tab can diverse according to the value passing from the context. I need to think how I will test it, but feedbacks are already very welcome :-)