Fixup return statement asset inlining #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 76.25% 76.23% -0.03%
==========================================
Files 10 10
Lines 1112 1111 -1
==========================================
- Hits 848 847 -1
Misses 264 264
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes up the asset emission case for
return '/path/to/asset'inlining the whole return statement and dropping thereturnkeyword.This was also the root bug for the TypeScript build actually, we just avoided it by workaround the
__dirnameemission as in this test case, but this fixes the root cause too in case it comes up elsewhere.