Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows pathing fixes #57

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Windows pathing fixes #57

merged 1 commit into from
Jun 25, 2019

Conversation

guybedford
Copy link
Contributor

This includes the fixes for windows paths support.

@codecov-io
Copy link

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   76.25%   76.25%           
=======================================
  Files          10       10           
  Lines        1112     1112           
=======================================
  Hits          848      848           
  Misses        264      264
Impacted Files Coverage Δ
src/asset-relocator.js 83.8% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5cff63...a174797. Read the comment docs.

@guybedford
Copy link
Contributor Author

Fast-tracking for release.

@guybedford guybedford merged commit 38ca963 into master Jun 25, 2019
@guybedford guybedford deleted the win-fixes branch June 25, 2019 22:56
guybedford added a commit that referenced this pull request Jul 2, 2019
@guybedford guybedford mentioned this pull request Jul 2, 2019
guybedford added a commit that referenced this pull request Jul 2, 2019
guybedford added a commit that referenced this pull request Jul 2, 2019
* use webpack public path in asset emission (#55)

* Windows pathing fixes (#57)
guybedford added a commit that referenced this pull request Jul 2, 2019
* use webpack public path in asset emission (#55)

* Windows pathing fixes (#57)
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants