Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove __dirname filtering #53

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Remove __dirname filtering #53

merged 1 commit into from
Jun 19, 2019

Conversation

guybedford
Copy link
Contributor

This removes the filtering that restricts emitting any __dirname references on their own that aren't analyzable as larger expressions.

The result is the risk of emitting more entire package directories unnecessarily, but this doesn't break anything in the ncc integration tests.

@codecov-io
Copy link

Codecov Report

Merging #53 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   76.03%   75.99%   -0.05%     
==========================================
  Files          10       10              
  Lines        1106     1104       -2     
==========================================
- Hits          841      839       -2     
  Misses        265      265
Impacted Files Coverage Δ
src/asset-relocator.js 83.44% <ø> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce6e501...39ca513. Read the comment docs.

@styfle styfle merged commit 729e438 into master Jun 19, 2019
@styfle styfle deleted the remove-dirname-filter branch June 19, 2019 18:29
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants