Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup require wrapper case handling #50

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Conversation

guybedford
Copy link
Contributor

This extends the support and coverage for the require wrapper detection and handling.

It also fixes a bug that was being thrown for invalid wrapper detection cases.

@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   76.03%   76.03%           
=======================================
  Files          10       10           
  Lines        1106     1106           
=======================================
  Hits          841      841           
  Misses        265      265
Impacted Files Coverage Δ
src/asset-relocator.js 83.49% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da8d65a...15e3d39. Read the comment docs.

@guybedford
Copy link
Contributor Author

Fast-tracking to release a ncc patch.

@guybedford guybedford merged commit 3d107d4 into master Jun 13, 2019
@guybedford guybedford deleted the require-wrapper-cases branch June 13, 2019 12:32
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants