Respect VcCellMode in TraitRef::cell #8870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
arlyon
approved these changes
Jul 31, 2024
|
Migrated to the next.js repo: vercel/next.js#68473 |
bgw
added a commit
to vercel/next.js
that referenced
this pull request
Aug 5, 2024
*This is a migrated PR. This was in the turbo repository before the next.js merge.* **Migrated From:** vercel/turborepo#8870 ### Description Building on the `VcCellMode::raw_cell` API from #68467 and the addition of `ValueType::raw_cell` in #68472, this fixes an edge case where `TraitRef::cell` didn't respect `VcCellMode` and acted like it was always using `cell = "new"`. I noticed this problem while working on local `Vc` resolution. Because `TraitRef` doesn't know the real concrete type at compile time, this wasn't possible to fix without these new type-erased `raw_cell` APIs. The consequences of this bug are mostly just that some data might get recomputed in certain rare edge cases (most stuff doesn't use `TraitRef`s heavily). ### Testing Instructions A regression test is included, which fails without the other changes included in this PR. ``` cargo nextest r -p turbo-tasks-memory trait_ref ```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
*This is a migrated PR. This was in the turbo repository before the next.js merge.* **Migrated From:** vercel/turborepo#8870 ### Description Building on the `VcCellMode::raw_cell` API from #68467 and the addition of `ValueType::raw_cell` in #68472, this fixes an edge case where `TraitRef::cell` didn't respect `VcCellMode` and acted like it was always using `cell = "new"`. I noticed this problem while working on local `Vc` resolution. Because `TraitRef` doesn't know the real concrete type at compile time, this wasn't possible to fix without these new type-erased `raw_cell` APIs. The consequences of this bug are mostly just that some data might get recomputed in certain rare edge cases (most stuff doesn't use `TraitRef`s heavily). ### Testing Instructions A regression test is included, which fails without the other changes included in this PR. ``` cargo nextest r -p turbo-tasks-memory trait_ref ```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
*This is a migrated PR. This was in the turbo repository before the next.js merge.* **Migrated From:** vercel/turborepo#8870 ### Description Building on the `VcCellMode::raw_cell` API from #68467 and the addition of `ValueType::raw_cell` in #68472, this fixes an edge case where `TraitRef::cell` didn't respect `VcCellMode` and acted like it was always using `cell = "new"`. I noticed this problem while working on local `Vc` resolution. Because `TraitRef` doesn't know the real concrete type at compile time, this wasn't possible to fix without these new type-erased `raw_cell` APIs. The consequences of this bug are mostly just that some data might get recomputed in certain rare edge cases (most stuff doesn't use `TraitRef`s heavily). ### Testing Instructions A regression test is included, which fails without the other changes included in this PR. ``` cargo nextest r -p turbo-tasks-memory trait_ref ```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
*This is a migrated PR. This was in the turbo repository before the next.js merge.* **Migrated From:** vercel/turborepo#8870 ### Description Building on the `VcCellMode::raw_cell` API from #68467 and the addition of `ValueType::raw_cell` in #68472, this fixes an edge case where `TraitRef::cell` didn't respect `VcCellMode` and acted like it was always using `cell = "new"`. I noticed this problem while working on local `Vc` resolution. Because `TraitRef` doesn't know the real concrete type at compile time, this wasn't possible to fix without these new type-erased `raw_cell` APIs. The consequences of this bug are mostly just that some data might get recomputed in certain rare edge cases (most stuff doesn't use `TraitRef`s heavily). ### Testing Instructions A regression test is included, which fails without the other changes included in this PR. ``` cargo nextest r -p turbo-tasks-memory trait_ref ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Building on the
VcCellMode::raw_cellAPI from #8870 and the addition ofValueType::raw_cellin #8826, this fixes an edge case whereTraitRef::celldidn't respectVcCellModeand acted like it was always usingcell = "new".I noticed this problem while working on local
Vcresolution. BecauseTraitRefdoesn't know the real concrete type at compile time, this wasn't possible to fix without these new type-erasedraw_cellAPIs.The consequences of this bug are mostly just that some data might get recomputed in certain rare edge cases (most stuff doesn't use
TraitRefs heavily).Testing Instructions
A regression test is included, which fails without the other changes included in this PR.