fix: don't escape base path in ecmascript runtime to allow for URLs #7093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
ForsakenHarmony
force-pushed
the
hrmny/pack-2282-turbopack-assetprefix-fix
branch
from
86fc5da to
d78de69
Compare
wbinnssmith
approved these changes
Jan 24, 2024
ForsakenHarmony
restored the
hrmny/pack-2282-turbopack-assetprefix-fix
branch
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jan 24, 2024
### Turbopack Updates * vercel/turborepo#7091 <!-- Tobias Koppers - lock reqwest to 0.11.17 due to build issues --> * vercel/turborepo#7080 <!-- Tobias Koppers - reduce work and tasks during module analysis --> * vercel/turborepo#7093 <!-- Leah - fix: don't escape base path in ecmascript runtime to allow for URLs --> Closes PACK-2282 Fixes #60891 via vercel/turborepo#7093
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…ercel/turborepo#7093) ### Description next's asset prefix can be a full URL, I think we can assume that the basepath itself is valid. we probably also want to ensure that the `chunkPath` never contains invalid URL characters at build time so we don't need to escape anything at all at runtime. Need to make sure it passes all next.js tests #61090 Closes PACK-2282
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…ercel/turborepo#7093) ### Description next's asset prefix can be a full URL, I think we can assume that the basepath itself is valid. we probably also want to ensure that the `chunkPath` never contains invalid URL characters at build time so we don't need to escape anything at all at runtime. Need to make sure it passes all next.js tests #61090 Closes PACK-2282
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…ercel/turborepo#7093) ### Description next's asset prefix can be a full URL, I think we can assume that the basepath itself is valid. we probably also want to ensure that the `chunkPath` never contains invalid URL characters at build time so we don't need to escape anything at all at runtime. Need to make sure it passes all next.js tests #61090 Closes PACK-2282
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…ercel/turborepo#7093) ### Description next's asset prefix can be a full URL, I think we can assume that the basepath itself is valid. we probably also want to ensure that the `chunkPath` never contains invalid URL characters at build time so we don't need to escape anything at all at runtime. Need to make sure it passes all next.js tests #61090 Closes PACK-2282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
next's asset prefix can be a full URL, I think we can assume that the basepath itself is valid.
we probably also want to ensure that the
chunkPathnever contains invalid URL characters at build time so we don't need to escape anything at all at runtime.Need to make sure it passes all next.js tests vercel/next.js#61090
Closes PACK-2282