remove ChunkingType::Separate #5419

sokra · 2023-06-29T07:42:04Z

Description

We don't need that.
That simplifies code

Also renames SeparateAsync to Async to simplify the name a bit

Testing Instructions

CI

vercel · 2023-06-29T07:42:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-basic-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2023 8:37am
examples-cra-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2023 8:37am
examples-designsystem-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2023 8:37am
examples-gatsby-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2023 8:37am
examples-kitchensink-blog	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2023 8:37am
examples-native-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2023 8:37am
examples-nonmonorepo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2023 8:37am
examples-svelte-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2023 8:37am
examples-tailwind-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2023 8:38am
examples-vite-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2023 8:38am
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2023 8:38am

github-actions · 2023-06-29T07:43:11Z

⚠️ This change may fail to build next-swc.

Logs

packages/next-swc/crates/next-core/src/app_source.rs:20:27: �[38;5;9merror[E0432]: unresolved import `turbopack_binding::turbopack::core::environment::EnvironmentIntention`
packages/next-swc/crates/next-core/src/next_client/context.rs:19:37: �[38;5;9merror[E0432]: unresolved import `turbopack_binding::turbopack::core::environment::EnvironmentIntention`
packages/next-swc/crates/next-core/src/next_edge/context.rs:13:40: �[38;5;9merror[E0432]: unresolved import `turbopack_binding::turbopack::core::environment::EnvironmentIntention`
packages/next-swc/crates/next-core/src/next_server/context.rs:14:17: �[38;5;9merror[E0432]: unresolved import `turbopack_binding::turbopack::core::environment::EnvironmentIntention`
packages/next-swc/crates/next-core/src/page_source.rs:19:27: �[38;5;9merror[E0432]: unresolved import `turbopack_binding::turbopack::core::environment::EnvironmentIntention`
packages/next-swc/crates/next-core/src/router.rs:23:27: �[38;5;9merror[E0432]: unresolved import `turbopack_binding::turbopack::core::environment::EnvironmentIntention`
packages/next-swc/crates/next-core/src/web_entry_source.rs:16:37: �[38;5;9merror[E0432]: unresolved import `turbopack_binding::turbopack::core::environment::EnvironmentIntention`
packages/next-swc/crates/next-core/src/next_client/context.rs:110:30: �[38;5;9merror[E0061]: this function takes 1 argument but 2 arguments were supplied
packages/next-swc/crates/next-core/src/next_edge/context.rs:69:30: �[38;5;9merror[E0061]: this function takes 1 argument but 2 arguments were supplied
packages/next-swc/crates/next-core/src/next_server/context.rs:253:30: �[38;5;9merror[E0061]: this function takes 1 argument but 2 arguments were supplied
packages/next-swc/crates/next-core/src/web_entry_source.rs:65:30: �[38;5;9merror[E0061]: this function takes 1 argument but 2 arguments were supplied
error: could not compile `next-core` (lib) due to 11 previous errors

See job summary for details

github-actions · 2023-06-29T07:59:44Z

🟢 CI successful 🟢

Thanks

github-actions · 2023-06-29T08:02:57Z

Linux Benchmark for `65aa710`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	8031.64µs ± 23.31µs	8158.32µs ± 35.94µs	+1.58%	+0.10%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	8031.64µs ± 23.31µs	8158.32µs ± 35.94µs	+1.58%	+0.10%
bench_hmr_to_eval/Turbopack CSR/1000 modules	7486.45µs ± 38.77µs	7580.19µs ± 167.33µs	+1.25%
bench_startup/Turbopack CSR/1000 modules	934.60ms ± 3.14ms	948.92ms ± 5.49ms	+1.53%

alexkirsz · 2023-06-29T08:29:23Z

crates/turbopack-css/src/chunk/single_item_chunk/reference.rs

-    fn chunking_type(&self) -> Result<ChunkingTypeOptionVc> {
-        Ok(ChunkingTypeOptionVc::cell(Some(ChunkingType::Separate)))
-    }
-}


Have you verified that this still produces a single CSS chunk for each source CSS asset?

I haven't, I guess the tests do that.

But the SingleItemCssChunkReference is used in references from CssChunk, which is in the output graph, where ChunkableAssetReference is not used at all. ChunkableAssetReference is only used in the module graph while determining the chunking.

github-actions · 2023-06-29T08:29:26Z

MacOS Benchmark for `65aa710`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.81ms ± 0.19ms	27.06ms ± 0.08ms	-2.68%	-0.69%
bench_hmr_to_eval/Turbopack CSR/1000 modules	26.22ms ± 0.07ms	26.91ms ± 0.06ms	+2.62%	+1.62%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.81ms ± 0.19ms	27.06ms ± 0.08ms	-2.68%	-0.69%
bench_hmr_to_eval/Turbopack CSR/1000 modules	26.22ms ± 0.07ms	26.91ms ± 0.06ms	+2.62%	+1.62%
bench_startup/Turbopack CSR/1000 modules	3300.83ms ± 19.37ms	3451.19ms ± 93.44ms	+4.56%

github-actions · 2023-07-03T08:54:57Z

Linux Benchmark for `e412035`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	7081.59µs ± 18.07µs	7115.00µs ± 34.80µs	+0.47%
bench_hmr_to_eval/Turbopack CSR/1000 modules	6614.32µs ± 60.65µs	6583.43µs ± 29.69µs	-0.47%
bench_startup/Turbopack CSR/1000 modules	934.35ms ± 2.45ms	936.30ms ± 4.28ms	+0.21%

vercel/turborepo#5397 ## Turbopack updates * vercel/turborepo#5419 * vercel/turborepo#5397

### Description We don't need that. That simplifies code Also renames SeparateAsync to Async to simplify the name a bit ### Testing Instructions CI

remove ChunkingType::Separate

ae94ccb

sokra requested a review from a team as a code owner June 29, 2023 07:42

turbo-orchestrator bot added the team: turbopack label Jun 29, 2023

vercel bot deployed to Preview – turbo-site June 29, 2023 07:42 View deployment

rename SeparateAsync to Async

e97074b

sokra requested a review from alexkirsz June 29, 2023 08:05

alexkirsz reviewed Jun 29, 2023

View reviewed changes

sokra requested a review from alexkirsz June 29, 2023 12:07

sokra enabled auto-merge (squash) June 29, 2023 13:20

Merge branch 'main' into sokra/remove-separate-chunking-type

a702d39

vercel bot deployed to Preview – examples-vite-web July 3, 2023 08:37 View deployment

vercel bot deployed to Preview – examples-cra-web July 3, 2023 08:37 View deployment

vercel bot deployed to Preview – examples-tailwind-web July 3, 2023 08:37 View deployment

vercel bot deployed to Preview – examples-svelte-web July 3, 2023 08:37 View deployment

vercel bot deployed to Preview – examples-designsystem-docs July 3, 2023 08:37 View deployment

vercel bot deployed to Preview – examples-gatsby-web July 3, 2023 08:37 View deployment

vercel bot deployed to Preview – examples-kitchensink-blog July 3, 2023 08:37 View deployment

vercel bot deployed to Preview – examples-basic-web July 3, 2023 08:37 View deployment

vercel bot deployed to Preview – examples-nonmonorepo July 3, 2023 08:37 View deployment

vercel bot deployed to Preview – examples-native-web July 3, 2023 08:37 View deployment

vercel bot deployed to Preview – turbo-site July 3, 2023 08:38 View deployment

alexkirsz approved these changes Jul 4, 2023

View reviewed changes

sokra merged commit e528ac2 into main Jul 4, 2023

sokra deleted the sokra/remove-separate-chunking-type branch July 4, 2023 11:33

alexkirsz mentioned this pull request Jul 4, 2023

Update CustomModuleType import vercel/next.js#52133

Merged

kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jul 4, 2023

Update CustomModuleType import (#52133)

13cfc2b

vercel/turborepo#5397 ## Turbopack updates * vercel/turborepo#5419 * vercel/turborepo#5397

shuding pushed a commit to vercel/next.js that referenced this pull request Jul 8, 2023

Update CustomModuleType import (#52133)

8e6bbf6

vercel/turborepo#5397 ## Turbopack updates * vercel/turborepo#5419 * vercel/turborepo#5397

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove ChunkingType::Separate #5419

remove ChunkingType::Separate #5419

sokra commented Jun 29, 2023 •

edited

Loading

vercel bot commented Jun 29, 2023 •

edited

Loading

github-actions bot commented Jun 29, 2023 •

edited

Loading

github-actions bot commented Jun 29, 2023 •

edited

Loading

github-actions bot commented Jun 29, 2023

alexkirsz Jun 29, 2023

sokra Jun 29, 2023 •

edited

Loading

github-actions bot commented Jun 29, 2023

github-actions bot commented Jul 3, 2023

remove ChunkingType::Separate #5419

remove ChunkingType::Separate #5419

Conversation

sokra commented Jun 29, 2023 • edited Loading

Description

Testing Instructions

vercel bot commented Jun 29, 2023 • edited Loading

github-actions bot commented Jun 29, 2023 • edited Loading

github-actions bot commented Jun 29, 2023 • edited Loading

🟢 CI successful 🟢

github-actions bot commented Jun 29, 2023

Linux Benchmark for 65aa710

alexkirsz Jun 29, 2023

Choose a reason for hiding this comment

sokra Jun 29, 2023 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jun 29, 2023

MacOS Benchmark for 65aa710

github-actions bot commented Jul 3, 2023

Linux Benchmark for e412035

sokra commented Jun 29, 2023 •

edited

Loading

vercel bot commented Jun 29, 2023 •

edited

Loading

github-actions bot commented Jun 29, 2023 •

edited

Loading

github-actions bot commented Jun 29, 2023 •

edited

Loading

Linux Benchmark for `65aa710`

sokra Jun 29, 2023 •

edited

Loading

MacOS Benchmark for `65aa710`

Linux Benchmark for `e412035`