Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure spaces client and test error handling #5372

Closed
wants to merge 2 commits into from
Closed

Restructure spaces client and test error handling #5372

wants to merge 2 commits into from

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Jun 23, 2023

Description

Testing Instructions

@vercel
Copy link

vercel bot commented Jun 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 5:08pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jun 23, 2023 5:08pm
examples-cra-web ⬜️ Ignored (Inspect) Jun 23, 2023 5:08pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Jun 23, 2023 5:08pm
examples-gatsby-web ⬜️ Ignored (Inspect) Jun 23, 2023 5:08pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 23, 2023 5:08pm
examples-native-web ⬜️ Ignored (Inspect) Jun 23, 2023 5:08pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Jun 23, 2023 5:08pm
examples-svelte-web ⬜️ Ignored (Inspect) Jun 23, 2023 5:08pm
examples-tailwind-web ⬜️ Ignored (Inspect) Jun 23, 2023 5:08pm
examples-vite-web ⬜️ Ignored (Inspect) Jun 23, 2023 5:08pm

@gsoltis gsoltis marked this pull request as ready for review June 23, 2023 17:19
@gsoltis gsoltis requested a review from a team as a code owner June 23, 2023 17:19
@gsoltis gsoltis requested review from chris-olszewski, NicholasLYang and arlyon and removed request for a team and chris-olszewski June 23, 2023 17:19
@gsoltis gsoltis marked this pull request as draft June 23, 2023 17:19
Base automatically changed from gsoltis/spaces_error_handling to main June 23, 2023 17:20
@gsoltis
Copy link
Contributor Author

gsoltis commented Jun 23, 2023

We don't need this, we directly use the correct path

@gsoltis gsoltis closed this Jun 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turborepo e2e tests
  • Formatting

See workflow summary for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

@arlyon arlyon Awaiting requested review from arlyon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gsoltis