Use wax for globbing #5014
Merged
Use wax for globbing #5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
gsoltis
requested review from
gsoltis,
chris-olszewski and
NicholasLYang
and removed request for
nathanhammond and
tknickman
arlyon
force-pushed
the
integration/globbing
branch
from
872d856
to
d9e1200
Compare
|
Benchmark failures are from switching to |
These are no longer valid because wax treats ^ as a regular character.
Incomplete character range expressions are all considered invalid.
|
This is pretty much ready for inclusion. I have split out commits for each class of test case change. I have a single remaining question regarding these tests: @gsoltis we have spoken at length about explicitly handling potentially traversing out of the base path but it seems from these test cases we are expected not to support that? |
gsoltis
pushed a commit
that referenced
this pull request
Jun 1, 2023
Co-authored-by: Greg Soltis <Greg Soltis>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR against
intregration/globbingDescription
The first implementation of globbing used a library called glob-match. It was chosen due to its large test suite derived from micromatch in the node ecosystem. However:
Wax Deviations From Doublestar / Micromatch
?) to a grapheme cluster. For example, 🇳🇴, which consists of 🇳 followed by 🇴 does not match.a[!a]bmatchesa/b(!!!)aa**ccdoes not matchaa/bb/cc, so to match the behaviour you must replace it withaa*/**/*/ccas well asaa*cc**/does match againsta/ameaning that trailing slashes are ignored*/**matches againstfoo(the doublestar matches against nothing, and the slash is collapsed!ais invalid out of the box since they don’t support!******and^{,a}is invalid (brackets cannot have zero-length matches)a/**/**/bis not supported (consecutive doublestars are rejected rather than collapsed)a*{*,b}is rejected because the capture is ambiguous (ie acc could capture a, ac, or acc)test/{foo/**,bar}/baz← this one is confusing to me/or*test/{foo/**,bar}/bazTesting Instructions
The tests in globwalk should be exhaustive.