Use streaming file reads when comparing for writes #4093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
Benchmark for 6fd5d29
Click to view full benchmark
|
sokra
reviewed
Mar 7, 2023
crates/turbo-tasks-fs/src/util.rs
Outdated
| /// continue to be returned until the full buffer has been consumed. This allows | ||
| /// us to skip the overhead of, eg, repeated sys calls to read from disk as we | ||
| /// process a smaller number of bytes. | ||
| pub struct AsyncBufReader<'a, T: AsyncRead + Unpin + Sized> { |
There was a problem hiding this comment.
What's the difference to https://docs.rs/tokio/latest/tokio/io/struct.BufReader.html?
There was a problem hiding this comment.
😳 I searched the docs for AsyncBufReader and not BufReader, and implemented this from scratch because I didn't find anything.
crates/turbo-tasks-fs/src/lib.rs
Outdated
| // So meta matches, and we have a file handle. Let's stream the contents to see | ||
| // if they match. | ||
| let mut new_contents = new_file.read(); | ||
| let mut old_contents = AsyncBufReader::new(&mut old_file); |
There was a problem hiding this comment.
Performance-wise it would probably be better to avoid the buffered reader here and just read directly from the old_file as much as possible. Probably requires a little bit more complicated compare logic to handle consumed positions.
There was a problem hiding this comment.
I think you're assuming reading from a file returns a buffer, and we're then copying from that buffer into our BufReader buffer. But that's not the case, the read() API requires you to maintain a buffer and that gets passed to the system to copy bytes into, reading doesn't return a system buffer.
So we can either maintain our own buffer in this loop, or we can reuse the buffer created as part of BufReader.
Benchmark for fbf69aa
Click to view full benchmark
|
jridgewell
force-pushed
the
jrl-fs-streaming-compare
branch
from
43e62c7 to
36b5d76
Compare
Benchmark for b22cce7
Click to view full benchmark
|
jridgewell
force-pushed
the
jrl-fs-streaming-compare
branch
from
fbc152f to
36b5d76
Compare
Benchmark for 8228312
Click to view full benchmark
|
alexkirsz
approved these changes
Mar 8, 2023
Co-authored-by: Alex Kirszenberg <[email protected]>
jridgewell
added
the
pr: automerge
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 8, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
Benchmark for 604a028
Click to view full benchmark
|
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 9, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 9, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 9, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 9, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 9, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 9, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 9, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 9, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 9, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 9, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 9, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
ijjk
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 9, 2023
# New Features - vercel/turborepo#3975 # Bug Fixes - vercel/turborepo#4129 - vercel/turborepo#4134 - vercel/turborepo#4062 # Performance - vercel/turborepo#4093
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Mar 10, 2023
### Description Following vercel#3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…4093) ### Description Following #3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…4093) ### Description Following #3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…4093) ### Description Following #3526, this reimplements `write(content)`'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write. ### Testing Instructions Wait for benchmarks. --------- Co-authored-by: Alex Kirszenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #3526, this reimplements
write(content)'s file comparison to stream the contents of the file. Not every file we write is massive, but some of the ones we generate are 100kb+. I hope this can reduce memory pressure a bit by using a consistent 8kb block size, instead of allocating a buffer for the full file contents just to check if we should write.Testing Instructions
Wait for benchmarks.