Add test case for Headers routing #3900

jridgewell · 2023-02-21T23:10:33Z

Adds a test case for #3897, ~~which can't be done now because support just landed on the Next.js side and they haven't published a new canary yet. This can be merged as soon as they do and we update our dep~~ #3895 updated us to today's 13.1.7-canary.25.

vercel · 2023-02-21T23:10:45Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
examples-basic-web	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 7, 2023 at 4:44AM (UTC)
examples-cra-web	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 7, 2023 at 4:44AM (UTC)
examples-designsystem-docs	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 7, 2023 at 4:44AM (UTC)
examples-kitchensink-blog	❌ Failed (Inspect)			Mar 7, 2023 at 4:44AM (UTC)
examples-native-web	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 7, 2023 at 4:44AM (UTC)
examples-nonmonorepo	❌ Failed (Inspect)			Mar 7, 2023 at 4:44AM (UTC)
examples-svelte-web	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 7, 2023 at 4:44AM (UTC)
examples-tailwind-web	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 7, 2023 at 4:44AM (UTC)
examples-vite-web	🔄 Building (Inspect)	Visit Preview	💬 Add your feedback	Mar 7, 2023 at 4:44AM (UTC)

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
turbo-site	⬜️ Ignored (Inspect)	Visit Preview		Mar 7, 2023 at 4:44AM (UTC)

github-actions · 2023-02-21T23:31:19Z

🟢 CI successful 🟢

Thanks

github-actions · 2023-02-22T00:24:53Z

Benchmark for `5eeca22`

Test	Base	PR	%	Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules	8324.02µs ± 53.80µs	8040.16µs ± 83.80µs	-3.41%	-0.11%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	9575.82µs ± 109.40µs	9643.11µs ± 98.05µs	+0.70%
bench_hmr_to_commit/Turbopack RCC/1000 modules	12.40ms ± 0.38ms	12.96ms ± 0.23ms	+4.51%
bench_hmr_to_commit/Turbopack RSC/1000 modules	497.15ms ± 2.15ms	495.99ms ± 1.90ms	-0.23%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9677.07µs ± 97.14µs	9760.59µs ± 73.57µs	+0.86%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8324.02µs ± 53.80µs	8040.16µs ± 83.80µs	-3.41%	-0.11%
bench_hmr_to_eval/Turbopack RCC/1000 modules	10.67ms ± 0.23ms	11.13ms ± 0.11ms	+4.29%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8698.23µs ± 66.84µs	8770.95µs ± 53.79µs	+0.84%
bench_hydration/Turbopack RCC/1000 modules	3670.78ms ± 20.75ms	3647.29ms ± 7.97ms	-0.64%
bench_hydration/Turbopack RSC/1000 modules	3331.71ms ± 9.20ms	3327.30ms ± 11.02ms	-0.13%
bench_hydration/Turbopack SSR/1000 modules	3378.68ms ± 13.67ms	3343.17ms ± 8.51ms	-1.05%
bench_startup/Turbopack CSR/1000 modules	2626.25ms ± 5.79ms	2653.93ms ± 8.52ms	+1.05%
bench_startup/Turbopack RCC/1000 modules	2249.43ms ± 5.40ms	2242.76ms ± 3.97ms	-0.30%
bench_startup/Turbopack RSC/1000 modules	2174.11ms ± 4.18ms	2187.58ms ± 5.94ms	+0.62%
bench_startup/Turbopack SSR/1000 modules	2050.21ms ± 2.35ms	2051.70ms ± 2.70ms	+0.07%

github-actions · 2023-02-22T02:55:16Z

Benchmark for `5b1ac12`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	10.15ms ± 0.08ms	10.23ms ± 0.07ms	+0.82%
bench_hmr_to_commit/Turbopack RCC/1000 modules	12.42ms ± 0.30ms	13.24ms ± 0.37ms	+6.56%
bench_hmr_to_commit/Turbopack RSC/1000 modules	508.92ms ± 1.70ms	510.32ms ± 1.02ms	+0.28%
bench_hmr_to_commit/Turbopack SSR/1000 modules	10.29ms ± 0.07ms	10.27ms ± 0.09ms	-0.23%
bench_hmr_to_eval/Turbopack CSR/1000 modules	9094.23µs ± 76.88µs	9198.02µs ± 81.72µs	+1.14%
bench_hmr_to_eval/Turbopack RCC/1000 modules	11.55ms ± 0.19ms	11.18ms ± 0.26ms	-3.18%
bench_hmr_to_eval/Turbopack SSR/1000 modules	9201.27µs ± 58.59µs	9273.02µs ± 90.73µs	+0.78%
bench_hydration/Turbopack RCC/1000 modules	3774.05ms ± 13.27ms	3801.04ms ± 19.57ms	+0.72%
bench_hydration/Turbopack RSC/1000 modules	3398.80ms ± 13.70ms	3409.39ms ± 8.74ms	+0.31%
bench_hydration/Turbopack SSR/1000 modules	3442.38ms ± 10.34ms	3455.94ms ± 9.95ms	+0.39%
bench_startup/Turbopack CSR/1000 modules	2703.59ms ± 4.74ms	2703.16ms ± 8.91ms	-0.02%
bench_startup/Turbopack RCC/1000 modules	2309.72ms ± 4.06ms	2310.78ms ± 9.14ms	+0.05%
bench_startup/Turbopack RSC/1000 modules	2233.38ms ± 6.47ms	2235.01ms ± 4.09ms	+0.07%
bench_startup/Turbopack SSR/1000 modules	2113.23ms ± 2.86ms	2106.69ms ± 3.77ms	-0.31%

github-actions · 2023-02-22T21:03:37Z

Benchmark for 7285d67

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack RSC/1000 modules	501.13ms ± 0.91ms	505.40ms ± 0.75ms	+0.85%	+0.19%
bench_startup/Turbopack RSC/1000 modules	2278.88ms ± 10.12ms	2316.51ms ± 5.83ms	+1.65%	+0.25%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	11.67ms ± 0.11ms	11.73ms ± 0.11ms	+0.54%
bench_hmr_to_commit/Turbopack RCC/1000 modules	16.86ms ± 0.14ms	16.22ms ± 0.27ms	-3.78%
bench_hmr_to_commit/Turbopack RSC/1000 modules	501.13ms ± 0.91ms	505.40ms ± 0.75ms	+0.85%	+0.19%
bench_hmr_to_commit/Turbopack SSR/1000 modules	11.65ms ± 0.07ms	11.56ms ± 0.10ms	-0.78%
bench_hmr_to_eval/Turbopack CSR/1000 modules	10.63ms ± 0.07ms	10.68ms ± 0.07ms	+0.44%
bench_hmr_to_eval/Turbopack RCC/1000 modules	14.34ms ± 0.45ms	14.61ms ± 0.25ms	+1.90%
bench_hmr_to_eval/Turbopack SSR/1000 modules	10.58ms ± 0.05ms	10.67ms ± 0.10ms	+0.90%
bench_hydration/Turbopack RCC/1000 modules	3804.42ms ± 10.94ms	3809.57ms ± 8.13ms	+0.14%
bench_hydration/Turbopack RSC/1000 modules	3468.44ms ± 17.20ms	3439.79ms ± 10.14ms	-0.83%
bench_hydration/Turbopack SSR/1000 modules	3333.85ms ± 8.27ms	3320.69ms ± 11.60ms	-0.39%
bench_startup/Turbopack CSR/1000 modules	2574.25ms ± 3.60ms	2570.18ms ± 9.91ms	-0.16%
bench_startup/Turbopack RCC/1000 modules	2321.87ms ± 8.34ms	2321.63ms ± 5.22ms	-0.01%
bench_startup/Turbopack RSC/1000 modules	2278.88ms ± 10.12ms	2316.51ms ± 5.83ms	+1.65%	+0.25%
bench_startup/Turbopack SSR/1000 modules	2062.25ms ± 4.49ms	2051.10ms ± 4.07ms	-0.54%

github-actions · 2023-02-24T21:26:19Z

Benchmark for `eae95db`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack RCC/1000 modules	15.41ms ± 0.08ms	15.78ms ± 0.06ms	+2.41%	+0.59%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	11.43ms ± 0.06ms	11.46ms ± 0.09ms	+0.26%
bench_hmr_to_commit/Turbopack RCC/1000 modules	15.41ms ± 0.08ms	15.78ms ± 0.06ms	+2.41%	+0.59%
bench_hmr_to_commit/Turbopack RSC/1000 modules	499.88ms ± 2.15ms	502.36ms ± 1.41ms	+0.50%
bench_hmr_to_commit/Turbopack SSR/1000 modules	11.33ms ± 0.12ms	11.46ms ± 0.10ms	+1.14%
bench_hmr_to_eval/Turbopack CSR/1000 modules	10.49ms ± 0.10ms	10.46ms ± 0.10ms	-0.34%
bench_hmr_to_eval/Turbopack RCC/1000 modules	14.21ms ± 0.17ms	14.41ms ± 0.23ms	+1.37%
bench_hmr_to_eval/Turbopack SSR/1000 modules	10.40ms ± 0.07ms	10.48ms ± 0.11ms	+0.80%
bench_hydration/Turbopack RCC/1000 modules	3806.38ms ± 13.07ms	3814.59ms ± 11.86ms	+0.22%
bench_hydration/Turbopack RSC/1000 modules	3496.10ms ± 15.14ms	3479.26ms ± 13.92ms	-0.48%
bench_hydration/Turbopack SSR/1000 modules	3365.84ms ± 14.30ms	3324.58ms ± 13.62ms	-1.23%
bench_startup/Turbopack CSR/1000 modules	2581.75ms ± 12.82ms	2541.25ms ± 12.02ms	-1.57%
bench_startup/Turbopack RCC/1000 modules	2355.69ms ± 6.14ms	2349.87ms ± 8.15ms	-0.25%
bench_startup/Turbopack RSC/1000 modules	2316.53ms ± 14.53ms	2310.54ms ± 12.93ms	-0.26%
bench_startup/Turbopack SSR/1000 modules	2075.32ms ± 8.04ms	2074.98ms ± 7.88ms	-0.02%

github-actions · 2023-03-02T18:46:31Z

Benchmark for `dc56f0b`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack RSC/1000 modules	497.26ms ± 1.59ms	492.06ms ± 0.86ms	-1.05%	-0.06%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	8875.13µs ± 27.21µs	8909.09µs ± 49.25µs	+0.38%
bench_hmr_to_commit/Turbopack RCC/1000 modules	13.02ms ± 0.14ms	12.96ms ± 0.12ms	-0.42%
bench_hmr_to_commit/Turbopack RSC/1000 modules	497.26ms ± 1.59ms	492.06ms ± 0.86ms	-1.05%	-0.06%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9152.91µs ± 29.37µs	9112.46µs ± 39.69µs	-0.44%
bench_hmr_to_eval/Turbopack CSR/1000 modules	7950.70µs ± 34.60µs	7971.71µs ± 43.21µs	+0.26%
bench_hmr_to_eval/Turbopack RCC/1000 modules	11.64ms ± 0.24ms	11.97ms ± 0.16ms	+2.83%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8258.85µs ± 43.48µs	8144.06µs ± 39.97µs	-1.39%
bench_hydration/Turbopack RCC/1000 modules	3606.94ms ± 9.13ms	3592.14ms ± 12.68ms	-0.41%
bench_hydration/Turbopack RSC/1000 modules	3228.69ms ± 9.32ms	3208.49ms ± 14.48ms	-0.63%
bench_hydration/Turbopack SSR/1000 modules	3281.12ms ± 5.22ms	3280.83ms ± 4.45ms	-0.01%
bench_startup/Turbopack CSR/1000 modules	2558.95ms ± 5.45ms	2554.92ms ± 6.16ms	-0.16%
bench_startup/Turbopack RCC/1000 modules	2128.69ms ± 3.65ms	2117.71ms ± 4.23ms	-0.52%
bench_startup/Turbopack RSC/1000 modules	2053.26ms ± 6.15ms	2049.54ms ± 3.74ms	-0.18%
bench_startup/Turbopack SSR/1000 modules	2032.38ms ± 2.88ms	2028.23ms ± 4.28ms	-0.20%

jridgewell · 2023-03-07T04:44:08Z

@wbinnssmith Do you mind reviewing?

github-actions · 2023-03-07T06:01:27Z

Benchmark for `3533e67`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	9057.03µs ± 34.71µs	8976.90µs ± 45.47µs	-0.88%
bench_hmr_to_commit/Turbopack RCC/1000 modules	11.51ms ± 0.24ms	11.55ms ± 0.22ms	+0.33%
bench_hmr_to_commit/Turbopack RSC/1000 modules	513.96ms ± 2.20ms	513.03ms ± 1.27ms	-0.18%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9179.43µs ± 26.51µs	9263.62µs ± 57.98µs	+0.92%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8029.88µs ± 37.79µs	8083.52µs ± 19.76µs	+0.67%
bench_hmr_to_eval/Turbopack RCC/1000 modules	10.33ms ± 0.07ms	10.17ms ± 0.09ms	-1.51%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8275.60µs ± 42.18µs	8361.74µs ± 57.77µs	+1.04%
bench_hydration/Turbopack RCC/1000 modules	3637.36ms ± 10.58ms	3641.97ms ± 12.59ms	+0.13%
bench_hydration/Turbopack RSC/1000 modules	3274.19ms ± 12.26ms	3289.34ms ± 9.91ms	+0.46%
bench_hydration/Turbopack SSR/1000 modules	3342.59ms ± 9.19ms	3345.98ms ± 8.18ms	+0.10%
bench_startup/Turbopack CSR/1000 modules	2614.49ms ± 9.20ms	2597.20ms ± 4.53ms	-0.66%
bench_startup/Turbopack RCC/1000 modules	2155.88ms ± 7.95ms	2160.63ms ± 4.35ms	+0.22%
bench_startup/Turbopack RSC/1000 modules	2080.33ms ± 5.91ms	2081.45ms ± 5.81ms	+0.05%
bench_startup/Turbopack SSR/1000 modules	2072.03ms ± 3.28ms	2075.28ms ± 4.12ms	+0.16%

jridgewell · 2023-03-20T20:38:24Z

Included in vercel/next.js#47264

jridgewell requested a review from a team as a code owner February 21, 2023 23:10

turbo-orchestrator bot added the team: turbopack label Feb 21, 2023

Add test case for Headers routing

79aca4e

jridgewell force-pushed the jrl-response-header-test branch from e3907dc to 79aca4e Compare February 22, 2023 01:43

vercel bot deployed to Preview – turbo-site February 22, 2023 01:44 View deployment

Merge branch 'main' into jrl-response-header-test

f75a836

vercel bot had a problem deploying to Preview – examples-kitchensink-blog February 22, 2023 19:51 Failure

vercel bot deployed to Preview – examples-vite-web February 22, 2023 19:51 View deployment

vercel bot had a problem deploying to Preview – examples-svelte-web February 22, 2023 19:51 Failure

vercel bot deployed to Preview – examples-tailwind-web February 22, 2023 19:51 View deployment

vercel bot deployed to Preview – examples-native-web February 22, 2023 19:51 View deployment

vercel bot deployed to Preview – examples-basic-web February 22, 2023 19:51 View deployment

vercel bot deployed to Preview – examples-designsystem-docs February 22, 2023 19:51 View deployment

vercel bot deployed to Preview – examples-cra-web February 22, 2023 19:51 View deployment

jridgewell added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 22, 2023

vercel bot deployed to Preview – turbo-site February 22, 2023 19:52 View deployment

vercel bot deployed to Preview – examples-nonmonorepo February 22, 2023 19:52 View deployment

Merge branch 'main' into jrl-response-header-test

fd59633

vercel bot deployed to Preview – examples-svelte-web February 24, 2023 20:17 View deployment

vercel bot deployed to Preview – examples-kitchensink-blog February 24, 2023 20:17 View deployment

vercel bot deployed to Preview – turbo-site February 24, 2023 20:18 View deployment

Merge branch 'main' into jrl-response-header-test

e52a66a

vercel bot deployed to Preview – examples-tailwind-web March 2, 2023 17:33 View deployment

vercel bot deployed to Preview – examples-basic-web March 2, 2023 17:33 View deployment

vercel bot deployed to Preview – examples-svelte-web March 2, 2023 17:33 View deployment

vercel bot deployed to Preview – examples-native-web March 2, 2023 17:33 View deployment

vercel bot deployed to Preview – examples-vite-web March 2, 2023 17:33 View deployment

vercel bot deployed to Preview – examples-designsystem-docs March 2, 2023 17:33 View deployment

vercel bot had a problem deploying to Preview – examples-kitchensink-blog March 2, 2023 17:33 Failure

vercel bot deployed to Preview – examples-cra-web March 2, 2023 17:34 View deployment

vercel bot had a problem deploying to Preview – examples-nonmonorepo March 2, 2023 17:34 Failure

vercel bot deployed to Preview – turbo-site March 2, 2023 17:34 View deployment

jridgewell requested review from sokra and wbinnssmith and removed request for sokra March 2, 2023 18:51

jridgewell enabled auto-merge (squash) March 7, 2023 04:43

Merge branch 'main' into jrl-response-header-test

5512764

jridgewell disabled auto-merge March 7, 2023 04:43

vercel bot deployed to Preview – examples-vite-web March 7, 2023 04:44 View deployment

vercel bot deployed to Preview – examples-cra-web March 7, 2023 04:44 View deployment

vercel bot deployed to Preview – examples-designsystem-docs March 7, 2023 04:44 View deployment

vercel bot had a problem deploying to Preview – examples-kitchensink-blog March 7, 2023 04:44 Failure

vercel bot deployed to Preview – examples-basic-web March 7, 2023 04:44 View deployment

vercel bot deployed to Preview – examples-native-web March 7, 2023 04:44 View deployment

vercel bot deployed to Preview – examples-svelte-web March 7, 2023 04:44 View deployment

vercel bot deployed to Preview – examples-tailwind-web March 7, 2023 04:44 View deployment

vercel bot had a problem deploying to Preview – examples-nonmonorepo March 7, 2023 04:44 Failure

jridgewell closed this Mar 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test case for Headers routing #3900

Add test case for Headers routing #3900

jridgewell commented Feb 21, 2023 •

edited

Loading

vercel bot commented Feb 21, 2023 •

edited

Loading

github-actions bot commented Feb 21, 2023 •

edited

Loading

github-actions bot commented Feb 22, 2023

github-actions bot commented Feb 22, 2023

github-actions bot commented Feb 22, 2023

github-actions bot commented Feb 24, 2023

github-actions bot commented Mar 2, 2023

jridgewell commented Mar 7, 2023

github-actions bot commented Mar 7, 2023

jridgewell commented Mar 20, 2023

Add test case for Headers routing #3900

Add test case for Headers routing #3900

Conversation

jridgewell commented Feb 21, 2023 • edited Loading

vercel bot commented Feb 21, 2023 • edited Loading

github-actions bot commented Feb 21, 2023 • edited Loading

🟢 CI successful 🟢

github-actions bot commented Feb 22, 2023

Benchmark for 5eeca22

github-actions bot commented Feb 22, 2023

Benchmark for 5b1ac12

github-actions bot commented Feb 22, 2023

Benchmark for 7285d67

github-actions bot commented Feb 24, 2023

Benchmark for eae95db

github-actions bot commented Mar 2, 2023

Benchmark for dc56f0b

jridgewell commented Mar 7, 2023

github-actions bot commented Mar 7, 2023

Benchmark for 3533e67

jridgewell commented Mar 20, 2023

jridgewell commented Feb 21, 2023 •

edited

Loading

vercel bot commented Feb 21, 2023 •

edited

Loading

github-actions bot commented Feb 21, 2023 •

edited

Loading

Benchmark for `5eeca22`

Benchmark for `5b1ac12`

Benchmark for `eae95db`

Benchmark for `dc56f0b`

Benchmark for `3533e67`