-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: preserve file permission #362
fix: preserve file permission #362
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/FBiFEm5tcwgBgrfirxfTVP1Gn2aQ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the call sites to pass 0
to preserve permissions?
turborepo/cli/internal/cache/cache_fs.go
Line 32 in 11665a9
err := fs.RecursiveCopyOrLinkFile(cachedFolder, target, fs.DirPermissions, true, true) |
turborepo/cli/internal/cache/cache_fs.go
Line 54 in 11665a9
if err := fs.CopyOrLinkFile(file, filepath.Join(f.cacheDirectory, hash, rel), fs.DirPermissions, fs.DirPermissions, true, true); err != nil { |
and in all of this file
and lastly here:
turborepo/cli/internal/run/run_state.go
Line 289 in 2ee2c40
if err := fs.CopyFile(chrometracing.Path(), name, fs.DirPermissions); err != nil { |
I just did that you requested @jaredpalmer and undo my draft commit.
Is there anything I can help with my changes to not break something?. I see potential test/documentation/onboarding improvement in the future, I am happy to help. |
This reverts commit 67e64ab.
This unfortunately is more involved change. The current implementation breaks binary executables |
Close #156
This is only draft if someone can have discussion with me it would be great