Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix imports in default arguments in functions #3292

Merged
merged 2 commits into from
Jan 12, 2023
Merged

fix imports in default arguments in functions #3292

merged 2 commits into from
Jan 12, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 12, 2023

No description provided.

@sokra sokra requested a review from a team as a code owner January 12, 2023 15:37
@vercel
Copy link

vercel bot commented Jan 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

10 Ignored Deployments
Name Status Preview Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
turbo-vite-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)

@alexkirsz
Copy link
Contributor

alexkirsz commented Jan 12, 2023 •
edited
Loading

image

Is there a way to make these files smaller? I don't see how we can possibly humanly validate a snapshot this large.

@sokra sokra merged commit 5ef85db into main Jan 12, 2023
@sokra sokra deleted the sokra/web-14-esm-symbols-not-replaced-when-used-as-a branch January 12, 2023 16:34
@github-actions
Copy link
Contributor

Benchmark for da9fa49

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8924.05µs ± 59.26µs 8851.09µs ± 71.79µs -0.82%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9117.10µs ± 64.69µs 9156.56µs ± 59.43µs +0.43%
bench_hmr_to_commit/Turbopack RSC/1000 modules 490.81ms ± 3.45ms 489.49ms ± 0.63ms -0.27%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8955.11µs ± 69.95µs 8921.43µs ± 49.65µs -0.38%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7885.73µs ± 76.28µs 7812.77µs ± 51.30µs -0.93%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7936.80µs ± 52.30µs 7962.57µs ± 72.16µs +0.32%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7976.59µs ± 82.82µs 7952.56µs ± 72.51µs -0.30%
bench_hydration/Turbopack RCC/1000 modules 3493.85ms ± 9.45ms 3488.88ms ± 15.27ms -0.14%
bench_hydration/Turbopack RSC/1000 modules 2992.63ms ± 9.37ms 2977.50ms ± 7.96ms -0.51%
bench_hydration/Turbopack SSR/1000 modules 2770.29ms ± 9.20ms 2768.37ms ± 12.33ms -0.07%
bench_startup/Turbopack CSR/1000 modules 1706.85ms ± 3.25ms 1708.21ms ± 6.03ms +0.08%
bench_startup/Turbopack RCC/1000 modules 2622.86ms ± 8.44ms 2624.66ms ± 9.90ms +0.07%
bench_startup/Turbopack RSC/1000 modules 2505.76ms ± 9.36ms 2507.46ms ± 11.17ms +0.07%
bench_startup/Turbopack SSR/1000 modules 2138.89ms ± 4.55ms 2131.39ms ± 4.80ms -0.35%

@github-actions
Copy link
Contributor

🟢 CI successful 🟢

Thanks

This was referenced Jan 20, 2023
Closed
Merged
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@sokra
fix imports in default arguments in functions (vercel/turborepo#3292)
94f7994
sokra added a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@sokra
fix imports in default arguments in functions (vercel/turborepo#3292)
2df0f48
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
fix imports in default arguments in functions (vercel/turborepo#3292)
cdbc3e8
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix imports in default arguments in functions (vercel/turborepo#3292)
f12b738
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
fix imports in default arguments in functions (vercel/turborepo#3292)
19be87b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @alexkirsz @ForsakenHarmony