Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide resolvedUrl to next.js for rendering #3267

Merged
merged 1 commit into from
Jan 12, 2023
Merged

provide resolvedUrl to next.js for rendering #3267

merged 1 commit into from
Jan 12, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 11, 2023

No description provided.

@sokra sokra requested a review from a team as a code owner January 11, 2023 17:33
@vercel
Copy link

vercel bot commented Jan 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 11, 2023 at 5:33PM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 11, 2023 at 5:33PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 11, 2023 at 5:33PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 11, 2023 at 5:33PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 11, 2023 at 5:33PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 11, 2023 at 5:33PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 11, 2023 at 5:33PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 11, 2023 at 5:33PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 11, 2023 at 5:33PM (UTC)
turbo-vite-web ⬜️ Ignored (Inspect) Jan 11, 2023 at 5:33PM (UTC)

@github-actions
Copy link
Contributor

Benchmark for 8e85688

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8045.45µs ± 51.54µs 8058.80µs ± 60.99µs +0.17%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8327.97µs ± 33.11µs 8336.43µs ± 52.44µs +0.10%
bench_hmr_to_commit/Turbopack RSC/1000 modules 472.91ms ± 2.97ms 470.96ms ± 2.41ms -0.41%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8095.73µs ± 88.74µs 8198.75µs ± 44.77µs +1.27%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7109.79µs ± 53.62µs 7140.06µs ± 27.68µs +0.43%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7255.47µs ± 39.62µs 7255.16µs ± 55.65µs -0.00%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7226.95µs ± 58.21µs 7158.85µs ± 60.50µs -0.94%
bench_hydration/Turbopack RCC/1000 modules 3317.44ms ± 14.19ms 3302.78ms ± 7.80ms -0.44%
bench_hydration/Turbopack RSC/1000 modules 2810.19ms ± 3.35ms 2804.86ms ± 9.21ms -0.19%
bench_hydration/Turbopack SSR/1000 modules 2640.85ms ± 9.75ms 2626.85ms ± 10.00ms -0.53%
bench_startup/Turbopack CSR/1000 modules 1638.17ms ± 6.52ms 1631.86ms ± 4.72ms -0.39%
bench_startup/Turbopack RCC/1000 modules 2495.99ms ± 6.79ms 2497.78ms ± 12.01ms +0.07%
bench_startup/Turbopack RSC/1000 modules 2402.22ms ± 9.93ms 2395.11ms ± 10.22ms -0.30%
bench_startup/Turbopack SSR/1000 modules 2055.61ms ± 4.05ms 2052.87ms ± 4.40ms -0.13%

@github-actions
Copy link
Contributor

🟢 CI successful 🟢

Thanks

@sokra sokra merged commit 2646d75 into main Jan 12, 2023
@sokra sokra deleted the sokra/web-394-some-context-properties-are-missing-for branch January 12, 2023 07:58
This was referenced Jan 20, 2023
Closed
Merged
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@sokra
provide resolvedUrl to next.js for rendering (vercel/turborepo#3267)
3770479
sokra added a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@sokra
provide resolvedUrl to next.js for rendering (vercel/turborepo#3267)
753de8b
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
provide resolvedUrl to next.js for rendering (vercel/turborepo#3267)
988e711
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
provide resolvedUrl to next.js for rendering (vercel/turborepo#3267)
76f9840
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
provide resolvedUrl to next.js for rendering (vercel/turborepo#3267)
a59cb72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @jridgewell