Skip to content

Commit

Permalink
Don't filter non-existent tasks in dry run (#1225)
Browse files Browse the repository at this point in the history
Related to #937 and #1135

When executing a dry run, don't short-circuit on tasks with a non-existent command. Instead, set the command to `<NONEXISTENT>` and include it in the display.
  • Loading branch information
Greg Soltis authored May 11, 2022
1 parent cc2b0e9 commit b6371de
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions cli/internal/run/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -734,9 +734,7 @@ func (c *RunCommand) executeDryRun(engine *core.Scheduler, g *completeGraph, tas
}
command, ok := pt.pkg.Scripts[pt.task]
if !ok {
c.Config.Logger.Debug("no task in package, skipping")
c.Config.Logger.Debug("done", "status", "skipped")
return nil
command = "<NONEXISTENT>"
}
ancestors, err := engine.TaskGraph.Ancestors(pt.taskID)
if err != nil {
Expand Down

1 comment on commit b6371de

@vercel
Copy link

@vercel vercel bot commented on b6371de May 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.