Skip to content

Commit

Permalink
ci(workflow): expands more wasi targets (#7862)
Browse files Browse the repository at this point in the history
### TL;DR

This pull request updates the build flags for the 'turbopack' wasm32-wasi target and increases the number of target packages.

### What changed?

In the GitHub workflow file for tests, the `cargo check` command for the 'turbopack-wasi' target now specifies the `CARGO_BUILD_TARGET` environment variable. Additionally, in the 'Cargo.toml' file, the list of packages that can be compiled against the wasm32-wasi target has been expanded to include more turbo-task related crates.

### How to test?

To test these changes, run the GitHub workflows and check whether the 'turbopack' build process and the associated tests succeed.

### Why make this change?

Updating the build flags and target packages for the wasm32-wasi build process in 'turbopack' may lead to better performance and broader feature support.
  • Loading branch information
kwonoj authored Mar 29, 2024
1 parent 060a146 commit 18a3dd1
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ jobs:
- name: Run cargo check for the wasi targets
run: |
RUSTFLAGS="-D warnings -A deprecated" cargo groups check turbopack-wasi --release
CARGO_BUILD_TARGET="wasm32-wasi-preview1-threads" RUSTFLAGS="-D warnings -A deprecated" cargo groups check turbopack-wasi --release
turbopack_rust_clippy:
needs: [turbopack_rust_check]
Expand Down
8 changes: 7 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,13 @@ turbopack = [
]

# List of the packages can be compiled against wasm32-wasi target.
turbopack-wasi = ["path:crates/turbo-tasks-hash"]
turbopack-wasi = [
"path:crates/turbo-tasks-auto-hash-map",
"path:crates/turbo-tasks-hash",
"path:crates/turbo-tasks-macro",
"path:crates/turbo-tasks-macros-shared",
"path:crates/turbo-tasks-build",
]

[workspace.lints.clippy]
too_many_arguments = "allow"
Expand Down

0 comments on commit 18a3dd1

Please sign in to comment.