Fix handling of international characters #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The character class `\w` only matches ASCII characters. By replacing it with a more permissive negated set, international (unicode) characters are handled correctly. Added tests for these international characters. All these tests fail without this fix.
dferber90
reviewed
Nov 11, 2021
|
Thanks a lot @SeriousBug . I would be great if this PR can get merged |
|
We forked the repo and applied this fix here: https://www.npmjs.com/package/@dendronhq/title We'll close the fork once this PR is merged, but it's up for anyone who might find it useful in the meantime. |
|
Thanks @SeriousBug. @leo @sergiodxa @leerob Sorry to pin you again, could you have a check on this PR, thanks a lot! |
|
Hi @leerob @leo @sergiodxa, could we have this pr merged if possible, it will fix #33 and #63, really appreciate it. |
dferber90
approved these changes
Feb 10, 2022
leerob
approved these changes
Feb 12, 2022
|
Thank you so much @dferber90 @leerob |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The character class
\wonly matches ASCII characters. By replacing it with a more permissive negated set, international (unicode) characters are handled correctly.Added tests for these international characters. All these tests fail without this fix.
Fixes #33
Let me know if there's any changes I can do to help this get merged.