Allow cache serialization and subscribers to know the updated key and type of event #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the latest update on this? Is this PR going to be merged? I really want this feature. |
|
+1, this feature would be really great to have! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a SWR DevTools with @cristianbgp and being able to serialize the cache (useful to download the current version) and to subscribe to specific keys will make the development way easier.
Right now I have some workarounds, iterating the whole cache to get all the keys for both, serializing and know what changed.
The new subscription function will also help build other libraries like https://github.com/sergiodxa/swr-sync-storage which are currently iterating the whole cache on each change to serialize it.
BTW, in a future PR I would like to make useSWR use cache.subcribe internally to get the updates, this will allow us to easily count active hooks and purge keys without subscribed as attempted in #92