-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove index.js
suffix of use-sync-external-store/shim
to support React Native
#2767
Remove index.js
suffix of use-sync-external-store/shim
to support React Native
#2767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
Status | Check | Issues by priority | |
---|---|---|---|
Passed | Secrets | 0 0 0 0 | View in Orca |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 21875d4:
|
Thank you! |
This has broken our prod builds, reproduced on node v14, v16.
|
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [swr](https://swr.vercel.app) ([source](https://togithub.com/vercel/swr)) | [`2.2.2` -> `2.2.4`](https://renovatebot.com/diffs/npm/swr/2.2.2/2.2.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/swr/2.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/swr/2.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/swr/2.2.2/2.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/swr/2.2.2/2.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/swr (swr)</summary> ### [`v2.2.4`](https://togithub.com/vercel/swr/releases/tag/v2.2.4) [Compare Source](https://togithub.com/vercel/swr/compare/v2.2.3...v2.2.4) ##### Patches - Revert "Remove `index.js` suffix of `use-sync-external-store/shim` to support React Native" by [@​huozhi](https://togithub.com/huozhi) in [https://github.com/vercel/swr/pull/2802](https://togithub.com/vercel/swr/pull/2802) **Full Changelog**: vercel/swr@v2.2.3...v2.2.4 ### [`v2.2.3`](https://togithub.com/vercel/swr/releases/tag/v2.2.3) [Compare Source](https://togithub.com/vercel/swr/compare/v2.2.2...v2.2.3) ##### Patches - fix: remove permissive type by [@​wcatron](https://togithub.com/wcatron) in [https://github.com/vercel/swr/pull/2759](https://togithub.com/vercel/swr/pull/2759) - Remove `index.js` suffix of `use-sync-external-store/shim` to support React Native by [@​malash](https://togithub.com/malash) in [https://github.com/vercel/swr/pull/2767](https://togithub.com/vercel/swr/pull/2767) - fix: default to fetch type in keyed mutator by [@​linkvt](https://togithub.com/linkvt) in [https://github.com/vercel/swr/pull/2753](https://togithub.com/vercel/swr/pull/2753) - types: export mutation types by [@​promer94](https://togithub.com/promer94) in [https://github.com/vercel/swr/pull/2780](https://togithub.com/vercel/swr/pull/2780) ##### Misc - test: update tests, use matched types for mutate api by [@​huozhi](https://togithub.com/huozhi) in [https://github.com/vercel/swr/pull/2781](https://togithub.com/vercel/swr/pull/2781) ##### New Contributors - [@​wcatron](https://togithub.com/wcatron) made their first contribution in [https://github.com/vercel/swr/pull/2759](https://togithub.com/vercel/swr/pull/2759) - [@​malash](https://togithub.com/malash) made their first contribution in [https://github.com/vercel/swr/pull/2767](https://togithub.com/vercel/swr/pull/2767) - [@​linkvt](https://togithub.com/linkvt) made their first contribution in [https://github.com/vercel/swr/pull/2753](https://togithub.com/vercel/swr/pull/2753) **Full Changelog**: vercel/swr@v2.2.2...v2.2.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [swr](https://swr.vercel.app) ([source](https://togithub.com/vercel/swr)) | [`2.2.2` -> `2.2.4`](https://renovatebot.com/diffs/npm/swr/2.2.2/2.2.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/swr/2.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/swr/2.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/swr/2.2.2/2.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/swr/2.2.2/2.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/swr (swr)</summary> ### [`v2.2.4`](https://togithub.com/vercel/swr/releases/tag/v2.2.4) [Compare Source](https://togithub.com/vercel/swr/compare/v2.2.3...v2.2.4) ##### Patches - Revert "Remove `index.js` suffix of `use-sync-external-store/shim` to support React Native" by [@​huozhi](https://togithub.com/huozhi) in [https://github.com/vercel/swr/pull/2802](https://togithub.com/vercel/swr/pull/2802) **Full Changelog**: vercel/swr@v2.2.3...v2.2.4 ### [`v2.2.3`](https://togithub.com/vercel/swr/releases/tag/v2.2.3) [Compare Source](https://togithub.com/vercel/swr/compare/v2.2.2...v2.2.3) ##### Patches - fix: remove permissive type by [@​wcatron](https://togithub.com/wcatron) in [https://github.com/vercel/swr/pull/2759](https://togithub.com/vercel/swr/pull/2759) - Remove `index.js` suffix of `use-sync-external-store/shim` to support React Native by [@​malash](https://togithub.com/malash) in [https://github.com/vercel/swr/pull/2767](https://togithub.com/vercel/swr/pull/2767) - fix: default to fetch type in keyed mutator by [@​linkvt](https://togithub.com/linkvt) in [https://github.com/vercel/swr/pull/2753](https://togithub.com/vercel/swr/pull/2753) - types: export mutation types by [@​promer94](https://togithub.com/promer94) in [https://github.com/vercel/swr/pull/2780](https://togithub.com/vercel/swr/pull/2780) ##### Misc - test: update tests, use matched types for mutate api by [@​huozhi](https://togithub.com/huozhi) in [https://github.com/vercel/swr/pull/2781](https://togithub.com/vercel/swr/pull/2781) ##### New Contributors - [@​wcatron](https://togithub.com/wcatron) made their first contribution in [https://github.com/vercel/swr/pull/2759](https://togithub.com/vercel/swr/pull/2759) - [@​malash](https://togithub.com/malash) made their first contribution in [https://github.com/vercel/swr/pull/2767](https://togithub.com/vercel/swr/pull/2767) - [@​linkvt](https://togithub.com/linkvt) made their first contribution in [https://github.com/vercel/swr/pull/2753](https://togithub.com/vercel/swr/pull/2753) **Full Changelog**: vercel/swr@v2.2.2...v2.2.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/huv1k/website). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR fixed #2402
According to this document, React Native-specific code can use the '.native.js' suffix, while standard React web code uses the '.js' suffix. By removing
index.js
suffix ofuse-sync-external-store/shim
, bundling tools like Metro/Webpack could choose the right file for each platform.I haven't tested this PR on React Native because I'm not familiar with React Native development and I have no idea how to downgrade React to 17. However, I can reproduce the issue and test the PR on GojiJS, which is a React-like framework based on
react-reconciler
and shares many technical specifications with React Native, including the '.native.js' suffix. It would be appreciated if anyone could help verify the changes.