Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more isLoading tests for the case a key is null or an error #2141

Merged
merged 2 commits into from
Aug 31, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 40 additions & 5 deletions test/use-swr-loading.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -321,14 +321,24 @@ describe('useSWR - loading', () => {
it('isLoading and isValidating should always respect cache value', async () => {
const key = createKey()
const Page = () => {
const { data } = useSWR(key, () => createResponse('result', { delay: 10 }))
const { data: response } = useSWR(data, () => createResponse('data', { delay: 10 }))
const { data } = useSWR(key, () =>
createResponse('result', { delay: 10 })
)
const { data: response } = useSWR(data, () =>
createResponse('data', { delay: 10 })
)
// eslint-disable-next-line react/display-name
const Component = ((_: any) => () => {
// eslint-disable-next-line react-hooks/rules-of-hooks
const { data: result, isLoading, isValidating } = useSWR(key, () => createResponse('result', { delay: 10 }))
const {
data: result,
isLoading,
isValidating
// eslint-disable-next-line react-hooks/rules-of-hooks
} = useSWR(key, () => createResponse('result', { delay: 10 }))
return (
<div>{`result is ${result ? result : 'null'},${isLoading},${isValidating}`}</div>
<div>{`result is ${
result ? result : 'null'
},${isLoading},${isValidating}`}</div>
)
})(response)
return <Component></Component>
Expand All @@ -337,4 +347,29 @@ describe('useSWR - loading', () => {
screen.getByText('result is null,true,true')
await screen.findByText('result is result,false,false')
})

it('isLoading should be false when key is null', () => {
function Page() {
const { isLoading } = useSWR(null, () => 'data')
return <div>isLoading:{String(isLoading)}</div>
}

renderWithConfig(<Page />)
screen.getByText('isLoading:false')
})

it('isLoading should be false when the key function throws an error', () => {
function Page() {
const { isLoading } = useSWR(
() => {
throw new Error('error')
},
() => 'data'
)
return <div>isLoading:{String(isLoading)}</div>
}

renderWithConfig(<Page />)
screen.getByText('isLoading:false')
})
})