Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused info from dummy package.json #2083

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jul 23, 2022

Closes #2081

Those subfolder package.json are created for providing module resolving for some bundler doesn't support exports field but need to resolve proper cjs or esm bundle. "name" and "version" fields are affecting webpack-license-plugin to extract the correct license, this PR will remove them before we deprecate those subfolder package.json to embrace the exports sugar

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 27cd3e8:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

@huozhi huozhi marked this pull request as ready for review July 23, 2022 13:10
@huozhi huozhi requested a review from shuding as a code owner July 23, 2022 13:10
@huozhi huozhi requested a review from promer94 July 23, 2022 13:10
@huozhi huozhi merged commit cde3e42 into main Jul 23, 2022
@huozhi huozhi deleted the rm-info-from-dummy-pkg-json branch July 23, 2022 16:34
huozhi added a commit that referenced this pull request Jul 24, 2022
@huozhi huozhi mentioned this pull request Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License issue in version 1.3.0
2 participants