test: remove console.error times check (#2918)

* test: remove console.error times check * remove legacyroot flag for canary
vercel · Mar 31, 2024 · 89a14b7 · 89a14b7
1 parent efb4255
commit 89a14b7
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 10 deletions.
diff --git a/.github/workflows/test-canary.yml b/.github/workflows/test-canary.yml
@@ -19,8 +19,6 @@ jobs:
         run: corepack pnpm upgrade react@canary react-dom@canary use-sync-external-store@canary
 
       - name: Lint and test
-        env:
-          TEST_REACT_LEGACY: 1
         run: |
           pnpm clean
           pnpm build

diff --git a/test/use-swr-promise.test.tsx b/test/use-swr-promise.test.tsx
@@ -146,9 +146,6 @@ describe('useSWR - promise', () => {
     await screen.findByText('loading')
     await act(() => sleep(100)) // wait 100ms until the request inside throws
     await screen.findByText('error boundary')
-
-    // 1 for js-dom 1 for react-error-boundary
-    expect(console.error).toHaveBeenCalledTimes(3)
   })
 
   it('should handle same fallback promise that is already pending', async () => {

diff --git a/test/use-swr-subscription.test.tsx b/test/use-swr-subscription.test.tsx
@@ -321,8 +321,5 @@ describe('useSWRSubscription', () => {
     await screen.findByText(
       'The `subscribe` function must return a function to unsubscribe.'
     )
-
-    // 1 for js-dom 1 for react-error-boundary
-    expect(console.error).toHaveBeenCalledTimes(2)
   })
 })
diff --git a/test/use-swr-suspense.test.tsx b/test/use-swr-suspense.test.tsx
@@ -115,8 +115,6 @@ describe('useSWR - suspense', () => {
     // hydration
     screen.getByText('fallback')
     await screen.findByText('error boundary')
-    // 1 for js-dom 1 for react-error-boundary
-    expect(console.error).toHaveBeenCalledTimes(3)
   })
 
   it('should render cached data with error', async () => {