Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify resolve tag + macro docs, add CRA section #596

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Clarify resolve tag + macro docs, add CRA section #596

merged 1 commit into from
Nov 8, 2019

Conversation

karlhorky
Copy link
Contributor

Hey @giuseppeg, thanks for this library!

As we discussed, here is a pull request that cleans up the docs around the resolve tag, Babel macros and adds a create-react-app section. More specifically, it:

  • Clarifies the use case of the resolve tag
  • Removes the extra, unrelated <style jsx> line from the resolve tag example
  • Makes a note of how the dynamic styles are supported (via template string interpolation)
  • Fixes some casing of Babel
  • Add some guidance / explainer text before the Babel macros installation instructions
  • Add a full Babel macros example
  • Add a section dedicated to create-react-app, with link to the project

If any of these things are questionable or you have some feedback, would be glad to discuss further!

@karlhorky karlhorky requested a review from giuseppeg as a code owner November 8, 2019 11:09
@giuseppeg giuseppeg merged commit cff1cae into vercel:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants