Fix source maps #551
Fix source maps #551
Conversation
src/_utils.js
Outdated
| @@ -591,7 +591,8 @@ export const processCss = (stylesInfo, options) => { | |||
|
|
|||
| if (useSourceMaps) { | |||
| const generator = makeSourceMapGenerator(fileInfo.file) | |||
| const filename = fileInfo.sourceFileName | |||
| const filename = fileInfo.sourceFileName || fileInfo.filename | |||
There was a problem hiding this comment.
The bug was here, these are not defined when not using the CLI I guess. Chances are that source maps still work when the plugin is used with babel loader or something.
There was a problem hiding this comment.
I started looking into this too and actually just opened a pr not seeing yours 🤦♂️
On my branch I used file.opts.generatorOpts.sourceFileName since it seems to match with the value we were expecting before. I closed it after seeing yours, but I just re-opened it so you can take a look.
src/_utils.js
Outdated
| // According to https://babeljs.io/docs/en/options#source-map-options | ||
| // filenameRelative = path.relative(file.opts.cwd, file.opts.filename) | ||
| // sourceFileName = path.basename(filenameRelative) | ||
| (fileInfo.filename && |
There was a problem hiding this comment.
@ijjk what do you think about this?
There was a problem hiding this comment.
This seems more stable than trying to follow where it's at in the options. Doesn't path.basename just return the last part of the path so the path.relative isn't necessary inside of the path.basename right?
Fixes #547