Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo explained in #509 #510

Closed
wants to merge 1 commit into from
Closed

Fix typo explained in #509 #510

wants to merge 1 commit into from

Conversation

ryanfitzer
Copy link
Contributor

@ryanfitzer ryanfitzer commented Oct 24, 2018

Fix typo explained in #509.

@giuseppeg
Copy link
Collaborator

to be honest I don't know exactly what is the difference between filename and sourceFileName:

https://github.com/zeit/styled-jsx/blob/1b3497517ec8743db3f236fe3191482578da121b/src/babel.js#L230-L238

I asked on the Babel slack community, let's wait for a reply.

The part you changed could be correct and the bug could be here https://github.com/zeit/styled-jsx/blob/1b3497517ec8743db3f236fe3191482578da121b/src/babel-external.js#L205-L209 (which is not computing and passing filename

@giuseppeg
Copy link
Collaborator

@ryanfitzer do you mind taking a look at these and see if sourceFileName is really what we need? I won't have time tonight/in the following days (maybe on Wed)

https://babeljs.io/docs/en/options#filename
https://babeljs.io/docs/en/options#filenamerelative
https://babeljs.io/docs/en/options#sourcefilename

@ryanfitzer
Copy link
Contributor Author

@lluisrojass If you get time, can you take a look at this before Wednesday? I won't have time until Monday.

@giuseppeg
Copy link
Collaborator

closed in favor of #526

@giuseppeg giuseppeg closed this Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants