Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better way to detect dynamic styles #401

Merged

Conversation

a-ignatov-parc
Copy link
Contributor

No description provided.

@a-ignatov-parc
Copy link
Contributor Author

@giuseppeg found another case when dynamic styles were detected as static. Tried to implement a better mechanism to detect them.

If you have other cases let me know 😉

@a-ignatov-parc a-ignatov-parc changed the title Universal way to detect dynamic styles Better way to detect dynamic styles Feb 4, 2018
@giuseppeg
Copy link
Collaborator

sweet thank you!

@giuseppeg giuseppeg merged commit d018577 into vercel:master Feb 4, 2018
@a-ignatov-parc a-ignatov-parc deleted the another-dynamic-styles-detection-fix branch February 4, 2018 13:24
@a-ignatov-parc
Copy link
Contributor Author

@giuseppeg can you share plans for the release of this fix?

@giuseppeg
Copy link
Collaborator

I want to include another fix, I'll try to get it out today or tomorrow

@a-ignatov-parc
Copy link
Contributor Author

No need to rush. Just curious about possible ETA 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants