Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dynamic styles detection #397

Merged
merged 2 commits into from
Jan 31, 2018

Conversation

a-ignatov-parc
Copy link
Contributor

@a-ignatov-parc a-ignatov-parc commented Jan 30, 2018

Fixed case when dynamic styles with compound props was detected as static

@a-ignatov-parc
Copy link
Contributor Author

@giuseppeg is there any chance we can get this fix released till Friday?

Don't want to rollback migration to styled-jsx just before release :)

@giuseppeg
Copy link
Collaborator

@a-ignatov-parc hi sorry, looks good.

Can you add two more tests:

const foo = 'red'
() => <div><style jsx>{`div { color: ${foo} }`}</style></div>

and one like the one you added but without the if? (without a block)

@a-ignatov-parc
Copy link
Contributor Author

Sure 👍

@a-ignatov-parc
Copy link
Contributor Author

Done. Looks good.

@giuseppeg giuseppeg merged commit 9b6635c into vercel:master Jan 31, 2018
@giuseppeg
Copy link
Collaborator

thanks man, I'll publish a patch release right away

@a-ignatov-parc
Copy link
Contributor Author

Awesome! Thanks a lot 🎉

@a-ignatov-parc a-ignatov-parc deleted the fix-dynamic-styles-detection branch January 31, 2018 09:26
@giuseppeg
Copy link
Collaborator

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants