Skip to content
This repository has been archived by the owner on Feb 11, 2025. It is now read-only.

Disable no-await-in-loop #63

Closed
mrmckeb opened this issue Jun 23, 2023 · 2 comments · Fixed by #95
Closed

Disable no-await-in-loop #63

mrmckeb opened this issue Jun 23, 2023 · 2 comments · Fixed by #95
Labels
enhancement New feature or request eslint released on @canary released
Milestone
v6

Comments

@mrmckeb
Copy link
Contributor

mrmckeb commented Jun 23, 2023

We've heard from engineers that this is a particularly painful rule. It seems mostly be an annoyance when working with scripts and CLIs (i.e. file read/write operations).

There are potentially two paths forward here:

  1. Enable it only for specific configs.
  2. Remove it completely.
@mrmckeb mrmckeb added the eslint label Jun 23, 2023
@mrmckeb mrmckeb added the enhancement New feature or request label Mar 4, 2024
@mrmckeb mrmckeb added this to the v6 milestone Mar 4, 2024
mrmckeb added a commit that referenced this issue Mar 4, 2024
@mrmckeb
feat(eslint): remove no-await-in-loop
925f8f9 
Closes #63

BREAKING CHANGE: `no-await-in-loop` has been removed.
@mrmckeb mrmckeb mentioned this issue Mar 4, 2024
Merged
mrmckeb added a commit that referenced this issue Mar 4, 2024
@mrmckeb
feat(eslint): make no-await-in-loop browser-only
2275538 
Closes #63

BREAKING CHANGE: `no-await-in-loop` is now only in the `browser` config.
mrmckeb added a commit that referenced this issue Mar 4, 2024
@mrmckeb
feat(eslint): remove no-await-in-loop rule
6b1a835 
Closes #63

BREAKING CHANGE: `no-await-in-loop` has been removed.
@vercel-release-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 5.3.0-canary.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vercel-release-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request eslint released on @canary released
Projects
None yet
Milestone
v6
Development

Successfully merging a pull request may close this issue.

feat(eslint): remove no-await-in-loop vercel/style-guide
2 participants
@mrmckeb @vercel-release-bot