Skip to content
This repository has been archived by the owner on Feb 11, 2025. It is now read-only.

Enable no-constant-binary-expression #23

Closed
codybrouwers opened this issue Jun 14, 2022 · 3 comments
Closed

Enable no-constant-binary-expression #23

codybrouwers opened this issue Jun 14, 2022 · 3 comments
Labels
eslint released on @canary released
Milestone
September 2022

Comments

@codybrouwers
Copy link
Member

codybrouwers commented Jun 14, 2022 •
edited
Loading

When we upgrade ESLint to 8.14.0 we should enable this rule:
https://eslint.org/docs/rules/no-constant-binary-expression

I tried enabling it and found two instances of easy to fix bugs.

Saw this recommended in this tweet
@kyh
Copy link

kyh commented Jun 15, 2022

I saw the same tweet and came here to post it ahah

@mrmckeb mrmckeb added this to the September 2022 milestone Sep 21, 2022
mrmckeb added a commit that referenced this issue Sep 21, 2022
@mrmckeb
feat(eslint): enable no-constant-binary-expression
662e35d 
Resolves #23
mrmckeb added a commit that referenced this issue Sep 21, 2022
@mrmckeb
feat(eslint): enable no-constant-binary-expression
6db7040 
Resolves #23
mrmckeb added a commit that referenced this issue Sep 21, 2022
@mrmckeb
feat(eslint): enable no-constant-binary-expression
966e85d 
Resolves #23
mrmckeb added a commit that referenced this issue Sep 21, 2022
@mrmckeb
feat(eslint): enable no-constant-binary-expression
5fa2275 
Resolves #23
@vercel-release-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 4.0.0-canary.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vercel-release-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eslint released on @canary released
Projects
None yet
Milestone
September 2022
Development

No branches or pull requests
4 participants
@kyh @mrmckeb @codybrouwers @vercel-release-bot