Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "etag" response header #94

Merged
merged 9 commits into from
Jul 10, 2019
Merged

Add "etag" response header #94

merged 9 commits into from
Jul 10, 2019

Conversation

TooTallNate
Copy link
Member

Utilize the etag module on npm to send an "etag" response header.

Utilize the `etag` module on npm to send an "etag" response header.
@TooTallNate TooTallNate requested a review from leo July 9, 2019 01:06
Copy link
Contributor

@leo leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to generate strong ETags, as the content is 100% static. In turn, I'd suggest generating a sha1 from the stream.

Also, from the package docs (but it's more or less obvious):

By default, a strong ETag is generated except for fs.Stats, which will generate a weak ETag.

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #94 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #94   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         324    324           
=====================================
  Hits          324    324

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3634a94...d771141. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #94 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #94   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         324    343   +19     
=====================================
+ Hits          324    343   +19
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3634a94...1e2bdfe. Read the comment docs.

README.md Outdated Show resolved Hide resolved
src/index.js Show resolved Hide resolved
@TooTallNate TooTallNate merged commit e7c4e42 into master Jul 10, 2019
@TooTallNate TooTallNate deleted the add/etag-response-header branch July 10, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants