Use GitHub Actions to run tests and publish #186
Conversation
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 342 342
=========================================
Hits 342 342 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| push: | ||
| branches: [master] | ||
| pull_request: | ||
| branches: [master] |
There was a problem hiding this comment.
In a follow up PR, lets change the branch to main
There was a problem hiding this comment.
👍 Yes, planned on doing that!
|
|
||
| on: | ||
| release: | ||
| types: [created] |
There was a problem hiding this comment.
How does this get invoked? Do we need to run npm version somewhere?
There was a problem hiding this comment.
As far as I understand, when a new release gets created on https://github.com/vercel/serve-handler/releases
So, we'd continue to run e.g. release to create a new version + update package.json + prepare the release. And once the release gets published/created, that action would run.
There was a problem hiding this comment.
I see, so there will still be a manual process and committing/pushing to main directly.
In the future, we might want to automate that part too 👍
There was a problem hiding this comment.
We’re using changesets/changesets in blockprotocol/blockprotocol, it works pretty well for managing changelogs & releases on GitHub!
Will remove Circle and change the required action once this PR got approved.