Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent path traversal vulnerabilities #14

Merged
merged 4 commits into from
May 30, 2018
Merged

Prevent path traversal vulnerabilities #14

merged 4 commits into from
May 30, 2018

Conversation

leo
Copy link
Contributor

@leo leo commented May 30, 2018

This will prevent things like ../../bla in the URL.

@leo leo added the enhancement New feature or request label May 30, 2018
@leo leo requested a review from timneutkens May 30, 2018 18:11
@codecov
Copy link

codecov bot commented May 30, 2018 •
edited
Loading

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #14   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         247    252    +5     
=====================================
+ Hits          247    252    +5
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 699258a...3f97480. Read the comment docs.

timneutkens
timneutkens requested changes May 30, 2018
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add integration tests for this

timneutkens
timneutkens approved these changes May 30, 2018
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leo leo merged commit 633928f into master May 30, 2018
@leo leo deleted the fix-path-traversal branch May 30, 2018 18:30
@leo leo mentioned this pull request May 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leo @timneutkens