patches: bump to 18.12.1, 16.18.1 and 14.21.1

[baparham]

fixes #259

all patches apply cleanly, but this is having some difficulty building locally. I tried building from v18.12.1 in vanilla node and it also fails, so I'm not sure if it's some issue with my build environment, but considering they are the same failure for vanilla as pkg-fetch, I'll submit this PR.

Here is the error output in case anybody has any ideas:

v8_initializers.vcxproj -> ..\..\out\Release\lib\v8_initializers.lib
  embedded-file-writer.cc
  mksnapshot.cc
C:\git\node\deps\v8\src\base\bits.h(340,31): warning C4146: unary minus operator applied to unsigned type, result still unsigned [C:\git\node\tools\v8_gypfiles\mksnapshot.vcxproj]
C:\git\node\deps\v8\src\base\bits.h(340,31): warning C4146: unary minus operator applied to unsigned type, result still unsigned [C:\git\node\tools\v8_gypfiles\mksnapshot.vcxproj]
     Creating library ..\..\out\Release\mksnapshot.lib and object ..\..\out\Release\mksnapshot.exp
mksnapshot.obj : error LNK2001: unresolved external symbol "public: class v8::internal::Object __cdecl v8::internal::FixedArray::get(int)const " (?get@FixedArray@internal@v8@@QEBA?AVObject@23@H@Z) [C:\git\nod
e\tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-aix.obj : error LNK2001: unresolved external symbol "public: class v8::internal::Object __cdecl v8::internal::FixedArray::get(int)const " (?get@FixedArray@internal@v8@@QEBA?AVObj
ect@23@H@Z) [C:\git\node\tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-generic.obj : error LNK2001: unresolved external symbol "public: class v8::internal::Object __cdecl v8::internal::FixedArray::get(int)const " (?get@FixedArray@internal@v8@@QEBA?A
VObject@23@H@Z) [C:\git\node\tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-mac.obj : error LNK2001: unresolved external symbol "public: class v8::internal::Object __cdecl v8::internal::FixedArray::get(int)const " (?get@FixedArray@internal@v8@@QEBA?AVObj
ect@23@H@Z) [C:\git\node\tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-win.obj : error LNK2001: unresolved external symbol "public: class v8::internal::Object __cdecl v8::internal::FixedArray::get(int)const " (?get@FixedArray@internal@v8@@QEBA?AVObj
ect@23@H@Z) [C:\git\node\tools\v8_gypfiles\mksnapshot.vcxproj]
..\..\out\Release\mksnapshot.exe : fatal error LNK1120: 1 unresolved externals [C:\git\node\tools\v8_gypfiles\mksnapshot.vcxproj]

[baparham]

based on nodejs/node#43092 and nodejs/node#39976 seems that my vs2022 isn't going to work with node due to a regression in msvc. I'll try and build with vs2019 tomorrow.

[robertsLando]

What's the problem with vs2022? Don't you use git diff > node-x.x.x.patch command to create patches?

[baparham]

The problem shows up on my system when I tried to build node to test out my patch

[baparham]

Also, I'm really not sure how you folks normally do patches, basically I just try and apply the existing patches on top of whatever tag in node.js I'm trying to upgrade to, but a plain git apply <patch> doesn't give me any help with partial success, like just running the applyScripts job from #251 or a build of the binary to see if the patches partially apply, or apply with offsets.

What is your normal workflow to update patch sets @robertsLando ?

[robertsLando]

What is your normal workflow to update patch sets @robertsLando ?

I never did it my self but what I would do is to apply existing ones and fix conflicts if any?

@jesec could help here but It's about one month or more that isn't that active, I think it's busy with job stuff

[baparham]

Thanks @robertsLando.

To throw a mention on #258 this could probably supersede that PR since these versions are newer and include more CVE fixes.

Also, is @jesec the only maintainer of this project currently? For things like this, where we have security critical upgrades needed, does it make sense to have some backup folks that can get things merged in and make releases?

[robertsLando]

There is also @leerob, at least I can merge this but releases are handled by him

[temaivanoff]

@jesec hi, when do you plan to release it?

p.s.: i found the answer, thnk 🎉