Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make styled-jsx optional. #968

Closed
wants to merge 1 commit into from
Closed

Make styled-jsx optional. #968

wants to merge 1 commit into from

Conversation

arunoda
Copy link
Contributor

@arunoda arunoda commented Feb 3, 2017

This fixes #964
This is to support plugins like styled-jsx-postcss

But I'd like to solve this from styled-jsx end. styled-jsx should parse the content only once.
Even it's included multiple times.

Since this works earlier, I think something got changed recently related to this in the styled-jsx side.
cc @rauchg @nkzawa @giuseppeg

This is to support plugins like styled-jsx-postcss
@rauchg
Copy link
Member

rauchg commented Feb 3, 2017

The problem with this option is that, if styled-jsx is not substituted the code will fail? Since we import the module for server rendering anyways ?

@arunoda
Copy link
Contributor Author

arunoda commented Feb 4, 2017

@rauchg other option is to make styled-jsx idempotent. Even it's added multiple times, it should run only once.

When I was reading the code, it seems like it's doing like that for <style> tags. But may be need to do it for adding the styled-jsx/style import.

@rauchg
Copy link
Member

rauchg commented Feb 12, 2017

@rauchg other option is to make styled-jsx idempotent. Even it's added multiple times, it should run only once.

Yes please

@rauchg rauchg closed this Feb 12, 2017
@arunoda arunoda deleted the fix-964 branch February 12, 2017 16:47
@arunoda
Copy link
Contributor Author

arunoda commented Feb 12, 2017

@rauchg I think we need to discuss this over in styled-jsx. I hope this task will be pretty simple for someone who knows about the styled-jsx code base.

@timneutkens
Copy link
Member

@arunoda vercel/styled-jsx#122

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants