Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for #8924 #9243

Merged
merged 5 commits into from
Oct 30, 2019
Merged

Add test for #8924 #9243

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f6895e
Add test for #8924
Timer Oct 30, 2019
ab03015
Merge branch 'canary' into test-no-amp-errors
Timer Oct 30, 2019
b892157
Merge branch 'canary' into test-no-amp-errors
Timer Oct 30, 2019
c432385
Merge branch 'canary' into test-no-amp-errors
Timer Oct 30, 2019
f3532c4
Merge branch 'canary' into test-no-amp-errors
Timer Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions test/integration/amphtml/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,27 @@ describe('AMP Usage', () => {
})
})

describe('AMP dev no-warn', () => {
let dynamicAppPort
let ampDynamic

it('should not warn on valid amp', async () => {
let inspectPayload = ''
dynamicAppPort = await findPort()
ampDynamic = await launchApp(join(__dirname, '../'), dynamicAppPort, {
onStdout (msg) {
inspectPayload += msg
}
})

await renderViaHTTP(dynamicAppPort, '/only-amp')

await killApp(ampDynamic)

expect(inspectPayload).not.toContain('warn')
})
})

describe('AMP dev mode', () => {
let dynamicAppPort
let ampDynamic
Expand Down