Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use service-worker to fetch only JSON pages. #924

Merged
merged 2 commits into from
Jan 30, 2017
Merged

Use service-worker to fetch only JSON pages. #924

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5812175
Use service-worker to fetch only JSON pages.
arunoda Jan 30, 2017
6570427
Use a better regexp to identify JSON pages.
arunoda Jan 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions client/next-prefetcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,8 @@ self.addEventListener('activate', (e) => {
})

self.addEventListener('fetch', (e) => {
const h = e.request.headers
const accept = h.getAll ? h.getAll('accept') : h.get('accept').split(',')
for (const a of accept) {
// bypass Server Sent Events
if (a === 'text/event-stream') return
}
// bypass all requests except JSON pages.
if (!(/\/_next\/[^/]+\/pages\//.test(e.request.url))) return
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkzawa I think we don't need this anymore?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we don't need this


e.respondWith(getResponse(e.request))
})
Expand Down