Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prerender Error Message #9143

Merged
merged 2 commits into from
Oct 20, 2019
Merged

Update Prerender Error Message #9143

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15b2bc4
Update Prerender Error Message
Timer Oct 20, 2019
bf2c8c5
Merge branch 'canary' into update-error-prerender-msg
Timer Oct 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next/export/worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ export default async function ({
await writeFileP(htmlFilepath, html, 'utf8')
return results
} catch (error) {
console.error(`\nError occurred prerendering ${path}:`, error)
console.error(`\nError occurred prerendering page "${path}":`, error)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.error(`\nError occurred prerendering page "${path}":`, error)
console.error(`\nError occurred prerendering path "${path}":`, error)

Won't calling this page add some confusion since we're logging the path not the page?

return { ...results, error: true }
}
}