Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix apollo server initialization in api-routes-apollo-server-and-client example #9137

Merged
merged 1 commit into from
Oct 21, 2019
Merged

fix apollo server initialization in api-routes-apollo-server-and-client example #9137

merged 1 commit into from
Oct 21, 2019

Conversation

none23
Copy link
Contributor

@none23 none23 commented Oct 19, 2019

I faced an issue similar to this one when using the code from the api-routes-apollo-server-and-client example. As suggested by this comment, passing typeDefs and resolvers both to makeExecutableSchema(...) and to new ApolloServer(...) results in two different schemas.

@none23 none23 requested review from lfades and Timer as code owners October 19, 2019 10:27
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@none23 Looks good, thank you 😌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants