Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[using-inferno] Update inferno to v7.3, fix missing React.createContext function #9038

Merged
merged 5 commits into from
Oct 16, 2019
Merged

[using-inferno] Update inferno to v7.3, fix missing React.createContext function #9038

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cf07abb
Update inferno examples to v7.3
rafaelalmeidatk Oct 11, 2019
cd9bdca
Add polyfill for React.createContext
rafaelalmeidatk Oct 11, 2019
fb74ebf
Alias react and react-dom with inferno-compat
rafaelalmeidatk Oct 12, 2019
ece656f
Fix linter errors
rafaelalmeidatk Oct 12, 2019
05be49b
Add warning about hooks and suspense support
rafaelalmeidatk Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/using-inferno/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,4 @@ This example uses [Inferno](https://github.com/infernojs/inferno), an insanely f
Here's how we did it:

- Use `next.config.js` to customize our webpack config to support [inferno-compat](https://www.npmjs.com/package/inferno-compat)
- Create `lib/inferno-compat.js` to polyfill the `React.createContext` API (required by Next.js) that is not available by `inferno-compat`
11 changes: 11 additions & 0 deletions examples/using-inferno/lib/inferno-compat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
const React = require('inferno-compat')
const createContext = require('create-react-context/lib/implementation')

Object.keys(React).forEach(key => {
if (key === 'default' || key === '__esModule') return
exports[key] = React[key]
})

// bypass export of React.createContext
exports.createContext = createContext
exports.default = React.default
7 changes: 4 additions & 3 deletions examples/using-inferno/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@
"start": "NODE_ENV=production node server.js"
},
"dependencies": {
"inferno": "^1.4.0",
"inferno-compat": "^1.4.0",
"inferno-server": "^1.4.0",
"create-react-context": "0.3.0",
"inferno": "7.3.2",
"inferno-compat": "7.3.2",
"inferno-server": "7.3.2",
"module-alias": "^2.0.0",
"next": "latest",
"react": "^16.7.0",
Expand Down
5 changes: 3 additions & 2 deletions examples/using-inferno/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
const port = parseInt(process.env.PORT, 10) || 3000
const dev = process.env.NODE_ENV !== 'production'
const moduleAlias = require('module-alias')
const path = require('path')

// For the development version, we'll use React.
// Because, it support react hot loading and so on.
if (!dev) {
moduleAlias.addAlias('react', 'inferno-compat')
moduleAlias.addAlias('react', path.resolve('./lib/inferno-compat.js'))
moduleAlias.addAlias('react-dom/server', 'inferno-server')
moduleAlias.addAlias('react-dom', 'inferno-compat')
moduleAlias.addAlias('react-dom', path.resolve('./lib/inferno-compat.js'))
}

const { createServer } = require('http')
Expand Down