Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unique identifier to router instance #9015

Merged
merged 5 commits into from
Oct 30, 2019
Merged

Add unique identifier to router instance #9015

merged 5 commits into from
Oct 30, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 9, 2019 •
edited
Loading

This removes the previous workaround that added an extra replaceState call on unload which is no longer working in Safari 13 since the unload event isn't firing.

This creates an id of the current time when the router is initialized and populates it in each changeState this way we can compare the current historyId with the historyId from the popstate event and see if it's a stale one or not.

Our external-and-back test in the production suite didn't catch that this is failing in Safari 13 since we are currently testing in Safari 12 and Safari 13 isn't available on BrowserStack yet. If you go through the test steps manually in Safari 13 you will be able to see the broken behavior before this PR and the corrected behavior with this PR

Fixes: #8871
x-ref: #6652

@ijjk
Copy link
Member Author

ijjk commented Oct 9, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/history-handling Change
buildDuration 15.6s 15.8s ⚠️ +212ms
nodeModulesSize 47.7 MB 47.7 MB -140 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..6604acae7.js 43.2 kB N/A N/A
de003c3a9d30..cae7.js gzip 15.5 kB N/A N/A
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
de003c3a9d30..70140fc19.js N/A 43.1 kB N/A
de003c3a9d30..fc19.js gzip N/A 15.5 kB N/A
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..42.module.js 45.6 kB N/A N/A
de003c3a9d30..dule.js gzip 16.5 kB N/A N/A
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
de003c3a9d30..fb.module.js N/A 45.5 kB N/A
de003c3a9d30..dule.js gzip N/A 16.5 kB N/A
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/history-handling Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js fix/history-handling Change
index.html 3.62 kB 3.62 kB ✓
index.html gzip 947 B 947 B ✓
link.html 3.66 kB 3.66 kB ✓
link.html gzip 955 B 954 B -1 B
withRouter.html 3.67 kB 3.67 kB ✓
withRouter.html gzip 943 B 941 B -2 B
Overall change 10.9 kB 10.9 kB ✓

Diffs

Diff for index.html 
@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.3eeaa079904675693c90.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -53,9 +53,9 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9e7d362a01a7a57a5210.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.bc8870b32c00cb2422b3.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.3eeaa079904675693c90.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>
Diff for link.html 
@@ -14,7 +14,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.3eeaa079904675693c90.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         as="script" crossorigin="anonymous" />
@@ -52,9 +52,9 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9e7d362a01a7a57a5210.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.bc8870b32c00cb2422b3.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.3eeaa079904675693c90.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
         async="" crossorigin="anonymous" nomodule=""></script>
Diff for withRouter.html 
@@ -14,7 +14,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.3eeaa079904675693c90.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         as="script" crossorigin="anonymous" />
@@ -50,9 +50,9 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9e7d362a01a7a57a5210.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.bc8870b32c00cb2422b3.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.3eeaa079904675693c90.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
         async="" crossorigin="anonymous" nomodule=""></script>
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/history-handling Change
buildDuration 16.3s 16s -323ms
nodeModulesSize 47.7 MB 47.7 MB -140 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..6604acae7.js 43.2 kB N/A N/A
de003c3a9d30..cae7.js gzip 15.5 kB N/A N/A
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
de003c3a9d30..70140fc19.js N/A 43.1 kB N/A
de003c3a9d30..fc19.js gzip N/A 15.5 kB N/A
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..42.module.js 45.6 kB N/A N/A
de003c3a9d30..dule.js gzip 16.5 kB N/A N/A
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
de003c3a9d30..fb.module.js N/A 45.5 kB N/A
de003c3a9d30..dule.js gzip N/A 16.5 kB N/A
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/history-handling Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/history-handling Change
_error.js 253 kB 254 kB ⚠️ +259 B
_error.js gzip 67.9 kB 68 kB ⚠️ +83 B
hooks.html 3.75 kB 3.75 kB ✓
hooks.html gzip 980 B 980 B ✓
index.js 254 kB 254 kB ⚠️ +259 B
index.js gzip 68.2 kB 68.3 kB ⚠️ +93 B
link.js 261 kB 262 kB ⚠️ +259 B
link.js gzip 70.3 kB 70.4 kB ⚠️ +92 B
routerDirect.js 255 kB 255 kB ⚠️ +259 B
routerDirect.js gzip 68.3 kB 68.4 kB ⚠️ +91 B
withRouter.js 254 kB 255 kB ⚠️ +259 B
withRouter.js gzip 68.4 kB 68.5 kB ⚠️ +94 B
Overall change 1.28 MB 1.28 MB ⚠️ +1.29 kB

Commit: 0aac594

@ijjk
Copy link
Member Author

ijjk commented Oct 10, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/history-handling Change
buildDuration 16.2s 16.3s ⚠️ +70ms
nodeModulesSize 47.7 MB 47.7 MB -268 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..6604acae7.js 43.2 kB N/A N/A
de003c3a9d30..cae7.js gzip 15.5 kB N/A N/A
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
de003c3a9d30..374589a71.js N/A 43.1 kB N/A
de003c3a9d30..9a71.js gzip N/A 15.4 kB N/A
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..42.module.js 45.6 kB N/A N/A
de003c3a9d30..dule.js gzip 16.5 kB N/A N/A
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
de003c3a9d30..97.module.js N/A 45.5 kB N/A
de003c3a9d30..dule.js gzip N/A 16.5 kB N/A
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/history-handling Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js fix/history-handling Change
index.html 3.62 kB 3.62 kB ✓
index.html gzip 947 B 946 B -1 B
link.html 3.66 kB 3.66 kB ✓
link.html gzip 955 B 953 B -2 B
withRouter.html 3.67 kB 3.67 kB ✓
withRouter.html gzip 943 B 941 B -2 B
Overall change 10.9 kB 10.9 kB ✓

Diffs

Diff for index.html 
@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7ce437c383ce5ead786a.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -53,9 +53,9 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9e7d362a01a7a57a5210.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f76c9a0297c242c2194.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7ce437c383ce5ead786a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>
Diff for link.html 
@@ -14,7 +14,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7ce437c383ce5ead786a.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         as="script" crossorigin="anonymous" />
@@ -52,9 +52,9 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9e7d362a01a7a57a5210.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f76c9a0297c242c2194.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7ce437c383ce5ead786a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
         async="" crossorigin="anonymous" nomodule=""></script>
Diff for withRouter.html 
@@ -14,7 +14,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7ce437c383ce5ead786a.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         as="script" crossorigin="anonymous" />
@@ -50,9 +50,9 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9e7d362a01a7a57a5210.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4f76c9a0297c242c2194.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7ce437c383ce5ead786a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
         async="" crossorigin="anonymous" nomodule=""></script>
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/history-handling Change
buildDuration 16.9s 16.9s -59ms
nodeModulesSize 47.7 MB 47.7 MB -268 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..6604acae7.js 43.2 kB N/A N/A
de003c3a9d30..cae7.js gzip 15.5 kB N/A N/A
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
de003c3a9d30..374589a71.js N/A 43.1 kB N/A
de003c3a9d30..9a71.js gzip N/A 15.4 kB N/A
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..42.module.js 45.6 kB N/A N/A
de003c3a9d30..dule.js gzip 16.5 kB N/A N/A
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
de003c3a9d30..97.module.js N/A 45.5 kB N/A
de003c3a9d30..dule.js gzip N/A 16.5 kB N/A
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/history-handling Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/history-handling Change
_error.js 253 kB 254 kB ⚠️ +197 B
_error.js gzip 67.9 kB 68 kB ⚠️ +68 B
hooks.html 3.75 kB 3.75 kB ✓
hooks.html gzip 980 B 976 B -4 B
index.js 254 kB 254 kB ⚠️ +197 B
index.js gzip 68.2 kB 68.3 kB ⚠️ +79 B
link.js 261 kB 262 kB ⚠️ +197 B
link.js gzip 70.3 kB 70.3 kB ⚠️ +77 B
routerDirect.js 255 kB 255 kB ⚠️ +197 B
routerDirect.js gzip 68.3 kB 68.4 kB ⚠️ +76 B
withRouter.js 254 kB 255 kB ⚠️ +197 B
withRouter.js gzip 68.4 kB 68.4 kB ⚠️ +78 B
Overall change 1.28 MB 1.28 MB ⚠️ +985 B

Commit: 005eb67

@ijjk
Copy link
Member Author

ijjk commented Oct 10, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/history-handling Change
buildDuration 16.2s 16.4s ⚠️ +150ms
nodeModulesSize 48.4 MB 48.4 MB -282 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..6604acae7.js 43.2 kB N/A N/A
de003c3a9d30..cae7.js gzip 15.5 kB N/A N/A
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
de003c3a9d30..6c6bc57f5.js N/A 43.1 kB N/A
de003c3a9d30..57f5.js gzip N/A 15.4 kB N/A
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..42.module.js 45.6 kB N/A N/A
de003c3a9d30..dule.js gzip 16.5 kB N/A N/A
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
de003c3a9d30..0a.module.js N/A 45.5 kB N/A
de003c3a9d30..dule.js gzip N/A 16.5 kB N/A
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/history-handling Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js fix/history-handling Change
index.html 3.62 kB 3.62 kB ✓
index.html gzip 947 B 947 B ✓
link.html 3.66 kB 3.66 kB ✓
link.html gzip 955 B 955 B ✓
withRouter.html 3.67 kB 3.67 kB ✓
withRouter.html gzip 943 B 942 B -1 B
Overall change 10.9 kB 10.9 kB ✓

Diffs

Diff for index.html 
@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.701787e5edbe72365000.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -53,9 +53,9 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9e7d362a01a7a57a5210.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.e5be79aa112f9eaf9a92.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.701787e5edbe72365000.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>
Diff for link.html 
@@ -14,7 +14,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.701787e5edbe72365000.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         as="script" crossorigin="anonymous" />
@@ -52,9 +52,9 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9e7d362a01a7a57a5210.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.e5be79aa112f9eaf9a92.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.701787e5edbe72365000.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
         async="" crossorigin="anonymous" nomodule=""></script>
Diff for withRouter.html 
@@ -14,7 +14,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.701787e5edbe72365000.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         as="script" crossorigin="anonymous" />
@@ -50,9 +50,9 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9e7d362a01a7a57a5210.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.e5be79aa112f9eaf9a92.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.701787e5edbe72365000.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
         async="" crossorigin="anonymous" nomodule=""></script>
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/history-handling Change
buildDuration 16.4s 16.7s ⚠️ +267ms
nodeModulesSize 48.4 MB 48.4 MB -282 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..6604acae7.js 43.2 kB N/A N/A
de003c3a9d30..cae7.js gzip 15.5 kB N/A N/A
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
de003c3a9d30..6c6bc57f5.js N/A 43.1 kB N/A
de003c3a9d30..57f5.js gzip N/A 15.4 kB N/A
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..42.module.js 45.6 kB N/A N/A
de003c3a9d30..dule.js gzip 16.5 kB N/A N/A
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
de003c3a9d30..0a.module.js N/A 45.5 kB N/A
de003c3a9d30..dule.js gzip N/A 16.5 kB N/A
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/history-handling Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/history-handling Change
_error.js 253 kB 254 kB ⚠️ +190 B
_error.js gzip 67.9 kB 68 kB ⚠️ +64 B
hooks.html 3.75 kB 3.75 kB ✓
hooks.html gzip 980 B 980 B ✓
index.js 254 kB 254 kB ⚠️ +190 B
index.js gzip 68.2 kB 68.3 kB ⚠️ +74 B
link.js 261 kB 262 kB ⚠️ +190 B
link.js gzip 70.3 kB 70.3 kB ⚠️ +69 B
routerDirect.js 255 kB 255 kB ⚠️ +190 B
routerDirect.js gzip 68.3 kB 68.3 kB ⚠️ +73 B
withRouter.js 254 kB 255 kB ⚠️ +190 B
withRouter.js gzip 68.4 kB 68.4 kB ⚠️ +75 B
Overall change 1.28 MB 1.28 MB ⚠️ +950 B

Commit: aec294e

@Timer Timer modified the milestones: 9.1.2, 9.1.3 Oct 30, 2019
@Timer Timer added Upstream Related to using Next.js with a third-party dependency. (e.g., React, UI/icon libraries, etc.). Type: Bug labels Oct 30, 2019
@Timer Timer changed the title Update to use a historyId to track invalid popstates Add unique identifier to router instance Oct 30, 2019
Timer
Timer approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as this is already tested and is simply a different implementation.

Funnily enough, it's what @timneutkens suggested in https://github.com/zeit/next.js/pull/6652/files#r266219003 😄.

@ijjk
Copy link
Member Author

ijjk commented Oct 30, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/history-handling Change
buildDuration 15.4s 15.7s ⚠️ +365ms
nodeModulesSize 48.4 MB 48.4 MB -282 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.js 16.6 kB 16.6 kB ✓
main-HASH.js gzip 5.85 kB 5.85 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..b6ebb586e.js 19.8 kB N/A N/A
16b1a7225520..586e.js gzip 7.25 kB N/A N/A
4952ddcd88e7..bfe360fe6.js 10.5 kB 10.5 kB ✓
4952ddcd88e7..0fe6.js gzip 4.06 kB 4.06 kB ✓
commons.HASH.js 11.3 kB 11.3 kB ✓
commons.HASH.js gzip 4.23 kB 4.23 kB ✓
de003c3a9d30..9e9c1d310.js 28.6 kB 28.6 kB ✓
de003c3a9d30..d310.js gzip 10.8 kB 10.8 kB ✓
framework.1b..cdcfe1283.js 125 kB 125 kB ✓
framework.1b..1283.js gzip 39.4 kB 39.4 kB ✓
16b1a7225520..63e75d588.js N/A 19.7 kB N/A
16b1a7225520..d588.js gzip N/A 7.23 kB N/A
Overall change 214 kB 214 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.module.js 14 kB 14 kB ✓
main-HASH.module.js gzip 5.25 kB 5.25 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..4c.module.js 15.9 kB N/A N/A
16b1a7225520..dule.js gzip 6.08 kB N/A N/A
4952ddcd88e7..4a.module.js 12.8 kB 12.8 kB ✓
4952ddcd88e7..dule.js gzip 4.75 kB 4.75 kB ✓
de003c3a9d30..c0.module.js 22.1 kB 22.1 kB ✓
de003c3a9d30..dule.js gzip 8.67 kB 8.67 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
16b1a7225520..51.module.js N/A 15.8 kB N/A
16b1a7225520..dule.js gzip N/A 6.06 kB N/A
Overall change 192 kB 192 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.js 1.63 kB 1.63 kB ✓
_app.js gzip 788 B 788 B ✓
_error.js 12.3 kB 12.3 kB ✓
_error.js gzip 4.79 kB 4.79 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 5.81 kB 5.81 kB ✓
link.js gzip 2.56 kB 2.56 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 22.8 kB 22.8 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.module.js 1.53 kB 1.53 kB ✓
_app.module.js gzip 749 B 749 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 792 B 792 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.47 kB 5.47 kB ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 20.1 kB 20.1 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/history-handling Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 200 B 199 B -1 B
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 210 B ⚠️ +1 B
Overall change 495 B 495 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js fix/history-handling Change
index.html 3.94 kB 3.94 kB ✓
index.html gzip 1 kB 1 kB ✓
link.html 4.47 kB 4.47 kB ✓
link.html gzip 1.08 kB 1.08 kB ✓
withRouter.html 4.47 kB 4.47 kB ✓
withRouter.html gzip 1.07 kB 1.07 kB -1 B
Overall change 12.9 kB 12.9 kB ✓

Diffs

Diff for _buildManifest.js 
@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.a1936a21395e34d00ee0.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
Diff for _buildManifest.module.js 
@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.8d1caa0eed52bc802a38.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
Diff for link.html 
@@ -18,7 +18,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.8d1caa0eed52bc802a38.module.js"
+        <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-ae31e9c8523198185767.module.js"
         as="script" crossorigin="anonymous" />
@@ -62,9 +62,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.a1936a21395e34d00ee0.js"
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.8d1caa0eed52bc802a38.module.js"
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-8c312b58ba8dc0eeb4e2.js"
         async="" crossorigin="anonymous" nomodule=""></script>
Diff for withRouter.html 
@@ -18,7 +18,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.8d1caa0eed52bc802a38.module.js"
+        <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/main-ae31e9c8523198185767.module.js"
         as="script" crossorigin="anonymous" />
@@ -60,9 +60,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.a1936a21395e34d00ee0.js"
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.8d1caa0eed52bc802a38.module.js"
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/main-8c312b58ba8dc0eeb4e2.js"
         async="" crossorigin="anonymous" nomodule=""></script>
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js fix/history-handling Change
buildDuration 15.7s 15.7s ⚠️ +3ms
nodeModulesSize 48.4 MB 48.4 MB -282 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.js 16.6 kB 16.6 kB ✓
main-HASH.js gzip 5.85 kB 5.85 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..b6ebb586e.js 19.8 kB N/A N/A
16b1a7225520..586e.js gzip 7.25 kB N/A N/A
4952ddcd88e7..bfe360fe6.js 10.5 kB 10.5 kB ✓
4952ddcd88e7..0fe6.js gzip 4.06 kB 4.06 kB ✓
commons.HASH.js 11.3 kB 11.3 kB ✓
commons.HASH.js gzip 4.23 kB 4.23 kB ✓
de003c3a9d30..9e9c1d310.js 28.6 kB 28.6 kB ✓
de003c3a9d30..d310.js gzip 10.8 kB 10.8 kB ✓
framework.1b..cdcfe1283.js 125 kB 125 kB ✓
framework.1b..1283.js gzip 39.4 kB 39.4 kB ✓
16b1a7225520..63e75d588.js N/A 19.7 kB N/A
16b1a7225520..d588.js gzip N/A 7.23 kB N/A
Overall change 214 kB 214 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
main-HASH.module.js 14 kB 14 kB ✓
main-HASH.module.js gzip 5.25 kB 5.25 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..4c.module.js 15.9 kB N/A N/A
16b1a7225520..dule.js gzip 6.08 kB N/A N/A
4952ddcd88e7..4a.module.js 12.8 kB 12.8 kB ✓
4952ddcd88e7..dule.js gzip 4.75 kB 4.75 kB ✓
de003c3a9d30..c0.module.js 22.1 kB 22.1 kB ✓
de003c3a9d30..dule.js gzip 8.67 kB 8.67 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
16b1a7225520..51.module.js N/A 15.8 kB N/A
16b1a7225520..dule.js gzip N/A 6.06 kB N/A
Overall change 192 kB 192 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.js 1.63 kB 1.63 kB ✓
_app.js gzip 788 B 788 B ✓
_error.js 12.3 kB 12.3 kB ✓
_error.js gzip 4.79 kB 4.79 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 5.81 kB 5.81 kB ✓
link.js gzip 2.56 kB 2.56 kB ✓
routerDirect.js 413 B 413 B ✓
routerDirect.js gzip 285 B 285 B ✓
withRouter.js 423 B 423 B ✓
withRouter.js gzip 284 B 284 B ✓
Overall change 22.8 kB 22.8 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js fix/history-handling Change
_app.module.js 1.53 kB 1.53 kB ✓
_app.module.js gzip 749 B 749 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 792 B 792 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.47 kB 5.47 kB ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 20.1 kB 20.1 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js fix/history-handling Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 200 B 199 B -1 B
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 210 B ⚠️ +1 B
Overall change 495 B 495 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary ijjk/next.js fix/history-handling Change
_error.js 241 kB 241 kB ✓
_error.js gzip 64.4 kB 64.4 kB ✓
hooks.html 4.08 kB 4.08 kB ✓
hooks.html gzip 1.03 kB 1.03 kB ✓
index.js 241 kB 241 kB ✓
index.js gzip 64.5 kB 64.5 kB ✓
link.js 274 kB 274 kB ⚠️ +190 B
link.js gzip 73.4 kB 73.5 kB ⚠️ +70 B
routerDirect.js 267 kB 267 kB ⚠️ +190 B
routerDirect.js gzip 71.5 kB 71.5 kB ⚠️ +78 B
withRouter.js 267 kB 267 kB ⚠️ +190 B
withRouter.js gzip 71.6 kB 71.6 kB ⚠️ +74 B
Overall change 1.29 MB 1.29 MB ⚠️ +570 B

Commit: 5d44ea2

@Timer Timer merged commit c4bef16 into vercel:canary Oct 30, 2019
@Timer Timer deleted the fix/history-handling branch October 30, 2019 02:50
@ijjk ijjk mentioned this pull request Nov 11, 2019
Merged
This was referenced Nov 19, 2019
Merged
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Janpot Janpot Janpot left review comments

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
Upstream Related to using Next.js with a third-party dependency. (e.g., React, UI/icon libraries, etc.).
Projects
None yet
Milestone
9.1.3
Development

Successfully merging this pull request may close these issues.

Safari back button from external page renders client side
3 participants
@ijjk @Timer @Janpot