Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next offline #9010

Merged
merged 3 commits into from
Oct 10, 2019
Merged

Next offline #9010

merged 3 commits into from
Oct 10, 2019

Conversation

armspkt
Copy link
Contributor

@armspkt armspkt commented Oct 9, 2019

Add example for next-offline with manifest.json for using google chrome app or install website to the standalone app via the mobile browser.

image

@armspkt armspkt requested review from lfades and Timer as code owners October 9, 2019 16:21
@ijjk
Copy link
Member

ijjk commented Oct 10, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary armspkt/next.js next-offline Change
buildDuration 15.4s 16.5s ⚠️ +1.1s
nodeModulesSize 47.7 MB 47.7 MB -21.1 kB
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary armspkt/next.js next-offline Change
main-HASH.js 18.9 kB 18.9 kB -9 B
main-HASH.js gzip 6.79 kB 6.78 kB -7 B
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB
de003c3a9d30..6604acae7.js 43.2 kB 43.2 kB
de003c3a9d30..cae7.js gzip 15.5 kB 15.5 kB
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
Overall change 211 kB 211 kB -9 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
zeit/next.js canary armspkt/next.js next-offline Change
main-HASH.module.js 17.2 kB 17.2 kB -9 B
main-HASH.module.js gzip 6.52 kB 6.51 kB -8 B
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..42.module.js 45.6 kB 45.6 kB
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
Overall change 190 kB 190 kB -9 B
Client Pages
zeit/next.js canary armspkt/next.js next-offline Change
_app.js 1.81 kB 1.81 kB
_app.js gzip 873 B 873 B
_error.js 12 kB 12 kB
_error.js gzip 4.73 kB 4.73 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.79 kB 4.79 kB
index.js 318 B 318 B
index.js gzip 222 B 222 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.5 kB 3.5 kB
routerDirect.js 408 B 408 B
routerDirect.js gzip 281 B 281 B
withRouter.js 419 B 419 B
withRouter.js gzip 280 B 280 B
Overall change 35.8 kB 35.8 kB
Client Pages Modern
zeit/next.js canary armspkt/next.js next-offline Change
_app.module.js 1.7 kB 1.7 kB
_app.module.js gzip 832 B 832 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.59 kB 8.59 kB
hooks.module.js 1.52 kB 1.52 kB
hooks.module.js gzip 793 B 793 B
index.module.js 294 B 294 B
index.module.js gzip 223 B 223 B
link.module.js 8.53 kB 8.53 kB
link.module.js gzip 3.68 kB 3.68 kB
routerDirect.module.js 394 B 394 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.module.js 404 B 404 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 36.1 kB 36.1 kB
Client Build Manifests
zeit/next.js canary armspkt/next.js next-offline Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Rendered Page Sizes
zeit/next.js canary armspkt/next.js next-offline Change
index.html 3.62 kB 3.62 kB
index.html gzip 947 B 946 B -1 B
link.html 3.66 kB 3.66 kB
link.html gzip 955 B 953 B -2 B
withRouter.html 3.67 kB 3.67 kB
withRouter.html gzip 943 B 941 B -2 B
Overall change 10.9 kB 10.9 kB

Diffs

Diff for main-HASH.js
@@ -368,7 +368,7 @@ if (!window.Promise) {
 
 var data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-var version = "9.1.2-canary.1";
+var version = "9.1.1";
 exports.version = version;
 var props = data.props,
     err = data.err,
Diff for main-HASH.module.js
@@ -425,7 +425,7 @@ if (!window.Promise) {
 
 const data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-const version = "9.1.2-canary.1";
+const version = "9.1.1";
 exports.version = version;
 const {
   props,
Diff for index.html
@@ -12,7 +12,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
+        <script src="/_next/static/runtime/main-7fec32669bede780888f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
+        <script src="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
Diff for link.html
@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -56,9 +56,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
+        <script src="/_next/static/runtime/main-7fec32669bede780888f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
+        <script src="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>
Diff for withRouter.html
@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -54,9 +54,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
+        <script src="/_next/static/runtime/main-7fec32669bede780888f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
+        <script src="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary armspkt/next.js next-offline Change
buildDuration 16.4s 16.2s -203ms
nodeModulesSize 47.7 MB 47.7 MB -21.1 kB
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary armspkt/next.js next-offline Change
main-HASH.js 18.9 kB 18.9 kB -9 B
main-HASH.js gzip 6.79 kB 6.78 kB -7 B
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB
de003c3a9d30..6604acae7.js 43.2 kB 43.2 kB
de003c3a9d30..cae7.js gzip 15.5 kB 15.5 kB
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
Overall change 211 kB 211 kB -9 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
zeit/next.js canary armspkt/next.js next-offline Change
main-HASH.module.js 17.2 kB 17.2 kB -9 B
main-HASH.module.js gzip 6.52 kB 6.51 kB -8 B
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..42.module.js 45.6 kB 45.6 kB
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
Overall change 190 kB 190 kB -9 B
Client Pages
zeit/next.js canary armspkt/next.js next-offline Change
_app.js 1.81 kB 1.81 kB
_app.js gzip 873 B 873 B
_error.js 12 kB 12 kB
_error.js gzip 4.73 kB 4.73 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.79 kB 4.79 kB
index.js 318 B 318 B
index.js gzip 222 B 222 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.5 kB 3.5 kB
routerDirect.js 408 B 408 B
routerDirect.js gzip 281 B 281 B
withRouter.js 419 B 419 B
withRouter.js gzip 280 B 280 B
Overall change 35.8 kB 35.8 kB
Client Pages Modern
zeit/next.js canary armspkt/next.js next-offline Change
_app.module.js 1.7 kB 1.7 kB
_app.module.js gzip 832 B 832 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.59 kB 8.59 kB
hooks.module.js 1.52 kB 1.52 kB
hooks.module.js gzip 793 B 793 B
index.module.js 294 B 294 B
index.module.js gzip 223 B 223 B
link.module.js 8.53 kB 8.53 kB
link.module.js gzip 3.68 kB 3.68 kB
routerDirect.module.js 394 B 394 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.module.js 404 B 404 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 36.1 kB 36.1 kB
Client Build Manifests
zeit/next.js canary armspkt/next.js next-offline Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Serverless bundles
zeit/next.js canary armspkt/next.js next-offline Change
_error.js 253 kB 253 kB
_error.js gzip 67.9 kB 67.9 kB ⚠️ +3 B
hooks.html 3.75 kB 3.75 kB
hooks.html gzip 980 B 979 B -1 B
index.js 254 kB 254 kB
index.js gzip 68.2 kB 68.2 kB ⚠️ +4 B
link.js 261 kB 261 kB
link.js gzip 70.3 kB 70.3 kB ⚠️ +2 B
routerDirect.js 255 kB 255 kB
routerDirect.js gzip 68.3 kB 68.3 kB ⚠️ +3 B
withRouter.js 254 kB 254 kB
withRouter.js gzip 68.4 kB 68.4 kB ⚠️ +4 B
Overall change 1.28 MB 1.28 MB

Commit: eb4964c

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants