Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not mix null in getCssLinks return value #8938

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Do not mix null in getCssLinks return value #8938

merged 2 commits into from
Oct 2, 2019

Conversation

Timer
Copy link
Member

@Timer Timer commented Oct 2, 2019

Minor nit, but previously the return type was:

(JSX.Element | null)[] | null

Now, it's simply:

JSX.Element[] | null

@Timer Timer added this to the 9.0.8 milestone Oct 2, 2019
@Timer Timer merged commit 80d574e into vercel:canary Oct 2, 2019
@Timer Timer deleted the simplify-get-css-files branch October 2, 2019 21:47
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@Timer @ijjk