New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in class name in with-react-esi example #8414

Merged

timneutkens merged 1 commit into vercel:canary from pogkat:patch-1

Aug 18, 2019

Contributor

pogkat commented Aug 18, 2019

No description provided.


          Typo in class name in with-react-esi example

70671ce

pogkat requested a review from lfades as a code owner

August 18, 2019 13:29

Member

ijjk commented Aug 18, 2019

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	pogkat/next.js patch-1	Change
buildDuration	25.5s	25.2s	-316ms
nodeModulesSize	41.3 MB	41.3 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	pogkat/next.js patch-1	Change
main-HASH.js	17.9 kB	17.9 kB	✓
main-HASH.js gzip	6.56 kB	6.56 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	pogkat/next.js patch-1	Change
main-HASH.module.js	16.2 kB	16.2 kB	✓
main-HASH.module.js gzip	6.28 kB	6.28 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			✓

Client Pages

	zeit/next.js canary	pogkat/next.js patch-1	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	600 B	600 B	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	290 B	290 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	pogkat/next.js patch-1	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Fetched pages

	zeit/next.js canary	pogkat/next.js patch-1	Change
link	2.8 kB	2.8 kB	✓
link gzip	848 B	850 B	⚠️ +2 B
index	2.75 kB	2.75 kB	✓
index gzip	840 B	842 B	⚠️ +2 B
withRouter	2.81 kB	2.81 kB	✓
withRouter gzip	836 B	838 B	⚠️ +2 B
Overall change			✓

Serverless Mode

General

	zeit/next.js canary	pogkat/next.js patch-1	Change
buildDuration	26.2s	27.2s	⚠️ +934ms
nodeModulesSize	41.3 MB	41.3 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	pogkat/next.js patch-1	Change
main-HASH.js	17.9 kB	17.9 kB	✓
main-HASH.js gzip	6.56 kB	6.56 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	pogkat/next.js patch-1	Change
main-HASH.module.js	16.2 kB	16.2 kB	✓
main-HASH.module.js gzip	6.28 kB	6.28 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			✓

Client Pages

	zeit/next.js canary	pogkat/next.js patch-1	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	600 B	600 B	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	290 B	290 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	pogkat/next.js patch-1	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Serverless bundles

	zeit/next.js canary	pogkat/next.js patch-1	Change
_error.js	247 kB	247 kB	✓
_error.js gzip	66.3 kB	66.3 kB	-1 B
hooks.html	2.87 kB	2.87 kB	✓
hooks.html gzip	868 B	866 B	-2 B
index.js	248 kB	248 kB	✓
index.js gzip	66.6 kB	66.6 kB	-1 B
link.js	255 kB	255 kB	✓
link.js gzip	68.8 kB	68.8 kB	-2 B
routerDirect.js	248 kB	248 kB	✓
routerDirect.js gzip	66.5 kB	66.5 kB	-1 B
withRouter.js	248 kB	248 kB	✓
withRouter.js gzip	66.6 kB	66.6 kB	✓
Overall change			✓

timneutkens approved these changes

View reviewed changes

timneutkens merged commit ef13f5c into vercel:canary

vercel locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet