Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples): correct the path in with-electron #8370

Merged
merged 2 commits into from
Aug 14, 2019
Merged

fix(examples): correct the path in with-electron #8370

merged 2 commits into from
Aug 14, 2019

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Aug 14, 2019 •
edited
Loading

Fix the production build of the with-electron example by pointing to the correct file.

Folder structure:
image

@merceyz merceyz requested a review from lfades as a code owner August 14, 2019 14:03
@ijjk
Copy link
Member

ijjk commented Aug 14, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary merceyz/next.js patch-1 Change
buildDuration 24.9s 24.6s -306ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary merceyz/next.js patch-1 Change
main-HASH.js 13.8 kB 13.8 kB ✓
main-HASH.js gzip 4.87 kB 4.87 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
commons.HASH.js 194 kB 194 kB ✓
commons.HASH.js gzip 63.1 kB 63.1 kB ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary merceyz/next.js patch-1 Change
main-HASH.module.js 11.4 kB 11.4 kB ✓
main-HASH.module.js gzip 4.31 kB 4.31 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
commons.HASH.module.js 176 kB 176 kB ✓
commons.HASH.module.js gzip 57.2 kB 57.2 kB ✓
Overall change ✓
Client Pages
zeit/next.js canary merceyz/next.js patch-1 Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 905 B 905 B ✓
_error.js 8.02 kB 8.02 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 4.07 kB 4.07 kB ✓
link.js gzip 1.79 kB 1.79 kB ✓
routerDirect.js 423 B 423 B ✓
routerDirect.js gzip 290 B 290 B ✓
withRouter.js 435 B 435 B ✓
withRouter.js gzip 287 B 286 B -1 B
Overall change ✓
Client Pages Modern
zeit/next.js canary merceyz/next.js patch-1 Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 865 B 865 B ✓
_error.module.js 5.82 kB 5.82 kB ✓
_error.module.js gzip 2.33 kB 2.33 kB ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 3.78 kB 3.78 kB ✓
link.module.js gzip 1.7 kB 1.7 kB -1 B
routerDirect.module.js 411 B 411 B ✓
routerDirect.module.js gzip 291 B 291 B ✓
withRouter.module.js 423 B 423 B ✓
withRouter.module.js gzip 288 B 288 B ✓
Overall change ✓
Fetched pages
zeit/next.js canary merceyz/next.js patch-1 Change
link 2.81 kB 2.81 kB ✓
link gzip 843 B 846 B ⚠️ +3 B
index 2.76 kB 2.76 kB ✓
index gzip 838 B 840 B ⚠️ +2 B
withRouter 2.82 kB 2.82 kB ✓
withRouter gzip 831 B 833 B ⚠️ +2 B
Overall change ✓
Serverless Mode
General
zeit/next.js canary merceyz/next.js patch-1 Change
buildDuration 25.8s 25.9s ⚠️ +144ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary merceyz/next.js patch-1 Change
main-HASH.js 13.8 kB 13.8 kB ✓
main-HASH.js gzip 4.87 kB 4.87 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
commons.HASH.js 194 kB 194 kB ✓
commons.HASH.js gzip 63.1 kB 63.1 kB ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary merceyz/next.js patch-1 Change
main-HASH.module.js 11.4 kB 11.4 kB ✓
main-HASH.module.js gzip 4.31 kB 4.31 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
commons.HASH.module.js 176 kB 176 kB ✓
commons.HASH.module.js gzip 57.2 kB 57.2 kB ✓
Overall change ✓
Client Pages
zeit/next.js canary merceyz/next.js patch-1 Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 905 B 905 B ✓
_error.js 8.02 kB 8.02 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 4.07 kB 4.07 kB ✓
link.js gzip 1.79 kB 1.79 kB ✓
routerDirect.js 423 B 423 B ✓
routerDirect.js gzip 290 B 290 B ✓
withRouter.js 435 B 435 B ✓
withRouter.js gzip 287 B 287 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary merceyz/next.js patch-1 Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 865 B 865 B ✓
_error.module.js 5.82 kB 5.82 kB ✓
_error.module.js gzip 2.33 kB 2.33 kB ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 3.78 kB 3.78 kB ✓
link.module.js gzip 1.7 kB 1.7 kB ✓
routerDirect.module.js 411 B 411 B ✓
routerDirect.module.js gzip 291 B 291 B ✓
withRouter.module.js 423 B 423 B ✓
withRouter.module.js gzip 288 B 288 B ✓
Overall change ✓
Serverless bundles
zeit/next.js canary merceyz/next.js patch-1 Change
_error.js 247 kB 247 kB ✓
_error.js gzip 66.2 kB 66.2 kB ✓
index.js 247 kB 247 kB ✓
index.js gzip 66.5 kB 66.5 kB -1 B
link.js 255 kB 255 kB ✓
link.js gzip 68.7 kB 68.7 kB ✓
routerDirect.js 248 kB 248 kB ✓
routerDirect.js gzip 66.4 kB 66.4 kB ✓
withRouter.js 248 kB 248 kB ✓
withRouter.js gzip 66.5 kB 66.5 kB -2 B
Overall change ✓

@ijjk
Copy link
Member

ijjk commented Aug 14, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary merceyz/next.js patch-1 Change
buildDuration 22.6s 23.4s ⚠️ +816ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary merceyz/next.js patch-1 Change
main-HASH.js 13.8 kB 13.8 kB ✓
main-HASH.js gzip 4.87 kB 4.87 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
commons.HASH.js 194 kB 194 kB ✓
commons.HASH.js gzip 63.1 kB 63.1 kB ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary merceyz/next.js patch-1 Change
main-HASH.module.js 11.4 kB 11.4 kB ✓
main-HASH.module.js gzip 4.31 kB 4.31 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
commons.HASH.module.js 176 kB 176 kB ✓
commons.HASH.module.js gzip 57.2 kB 57.2 kB ✓
Overall change ✓
Client Pages
zeit/next.js canary merceyz/next.js patch-1 Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 905 B 905 B ✓
_error.js 8.02 kB 8.02 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 4.07 kB 4.07 kB ✓
link.js gzip 1.79 kB 1.79 kB ✓
routerDirect.js 423 B 423 B ✓
routerDirect.js gzip 290 B 290 B ✓
withRouter.js 435 B 435 B ✓
withRouter.js gzip 287 B 287 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary merceyz/next.js patch-1 Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 865 B 865 B ✓
_error.module.js 5.82 kB 5.82 kB ✓
_error.module.js gzip 2.33 kB 2.33 kB ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 3.78 kB 3.78 kB ✓
link.module.js gzip 1.7 kB 1.7 kB ✓
routerDirect.module.js 411 B 411 B ✓
routerDirect.module.js gzip 291 B 291 B ✓
withRouter.module.js 423 B 423 B ✓
withRouter.module.js gzip 288 B 288 B ✓
Overall change ✓
Fetched pages
zeit/next.js canary merceyz/next.js patch-1 Change
link 2.81 kB 2.81 kB ✓
link gzip 848 B 846 B -2 B
index 2.76 kB 2.76 kB ✓
index gzip 840 B 839 B -1 B
withRouter 2.82 kB 2.82 kB ✓
withRouter gzip 834 B 833 B -1 B
Overall change ✓
Serverless Mode
General
zeit/next.js canary merceyz/next.js patch-1 Change
buildDuration 25.2s 25.2s ⚠️ +5ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary merceyz/next.js patch-1 Change
main-HASH.js 13.8 kB 13.8 kB ✓
main-HASH.js gzip 4.87 kB 4.87 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
commons.HASH.js 194 kB 194 kB ✓
commons.HASH.js gzip 63.1 kB 63.1 kB ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary merceyz/next.js patch-1 Change
main-HASH.module.js 11.4 kB 11.4 kB ✓
main-HASH.module.js gzip 4.31 kB 4.31 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
commons.HASH.module.js 176 kB 176 kB ✓
commons.HASH.module.js gzip 57.2 kB 57.2 kB ✓
Overall change ✓
Client Pages
zeit/next.js canary merceyz/next.js patch-1 Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 905 B 905 B ✓
_error.js 8.02 kB 8.02 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 4.07 kB 4.07 kB ✓
link.js gzip 1.79 kB 1.79 kB ✓
routerDirect.js 423 B 423 B ✓
routerDirect.js gzip 290 B 290 B ✓
withRouter.js 435 B 435 B ✓
withRouter.js gzip 287 B 287 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary merceyz/next.js patch-1 Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 865 B 865 B ✓
_error.module.js 5.82 kB 5.82 kB ✓
_error.module.js gzip 2.33 kB 2.33 kB ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 3.78 kB 3.78 kB ✓
link.module.js gzip 1.7 kB 1.7 kB ✓
routerDirect.module.js 411 B 411 B ✓
routerDirect.module.js gzip 291 B 291 B ✓
withRouter.module.js 423 B 423 B ✓
withRouter.module.js gzip 288 B 288 B ✓
Overall change ✓
Serverless bundles
zeit/next.js canary merceyz/next.js patch-1 Change
_error.js 247 kB 247 kB ✓
_error.js gzip 66.2 kB 66.2 kB -2 B
index.js 247 kB 247 kB ✓
index.js gzip 66.5 kB 66.5 kB -2 B
link.js 255 kB 255 kB ✓
link.js gzip 68.7 kB 68.7 kB -1 B
routerDirect.js 248 kB 248 kB ✓
routerDirect.js gzip 66.4 kB 66.4 kB -1 B
withRouter.js 248 kB 248 kB ✓
withRouter.js gzip 66.5 kB 66.5 kB -1 B
Overall change ✓

@lfades
Copy link
Member

lfades commented Aug 14, 2019

@merceyz I want to merge this, but actually I don't understand how this example works, start is used to start the development server and it works without this change, build and dist work too, I assume that this fixes running the app built by dist, but how do you run it?

@timneutkens timneutkens merged commit a7baeb0 into vercel:canary Aug 14, 2019
@merceyz
Copy link
Contributor Author

merceyz commented Aug 14, 2019 •
edited
Loading

I assume that this fixes running the app built by dist, but how do you run it?

Correct, I tested it using

yarn dist && dist/win-unpacked/ElectronNext.exe

Something else is wrong with the packing as it's including all files, then copying the content of out (see screenshot in OP). Tried to fix that as well but couldn't get it to load the JS, could you take a look?

@merceyz merceyz deleted the patch-1 branch August 14, 2019 19:14
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@merceyz @ijjk @lfades @timneutkens